github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-27 05:27:21 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #72167 from brahmaroutu/conformance_context

Browse Source 
Comment association to ConformanceIt block should be validated properly.
This commit is contained in:
Kubernetes Prow Robot 2019-05-08 20:12:48 -07:00 committed by GitHub
commit 7f86cb140f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 32 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
test/conformance/walk.go
View File

@ -166,8 +166,26 @@ func (v *visitor) failf(expr ast.Expr, format string, a ...interface{}) {
func (v *visitor) comment(x *ast.BasicLit) string { func (v *visitor) comment(x *ast.BasicLit) string {
for _, comm := range v.cMap.Comments() { for _, comm := range v.cMap.Comments() {
testOffset := int(x.Pos()-comm.End()) - len("framework.ConformanceIt(\"") testOffset := int(x.Pos()-comm.End()) - len("framework.ConformanceIt(\"")
if 0 < testOffset && testOffset < 3 { //Cannot assume the offset is within three or four tabs from the test block itself.
return comm.Text() //It is better to trim the newlines, tabs, etc and then we if the comment is followed
//by the test block itself so that we can associate the comment with it properly.
if 0 <= testOffset && testOffset <= 10 {
b1 := make([]byte, x.Pos()-comm.End())
//if we fail to open the file to compare the content we just assume the
//proximity of the comment and apply it.
myf, err := os.Open(v.FileSet.File(x.Pos()).Name())
if err == nil {
if _, err := myf.Seek(int64(comm.End()), 0); err == nil {
if _, err := myf.Read(b1); err == nil {
if strings.Compare(strings.Trim(string(b1), "\t \r\n"), "framework.ConformanceIt(\"") == 0 {
return comm.Text()
}
}
}
} else {
//comment section's end is noticed within 10 characters from framework.ConformanceIt block
return comm.Text()
}
} }
} }
return "" return ""

12
test/conformance/walk_test.go
View File

@ -80,6 +80,18 @@ var _ = framework.KubeDescribe("Feature", func() {
Description: `By default the stdout and stderr from the process Description: `By default the stdout and stderr from the process
being executed in a pod MUST be sent to the pod's logs.` + "\n\n"}}, being executed in a pod MUST be sent to the pod's logs.` + "\n\n"}},
}, },
{"e2e/foo.go", `
var _ = framework.KubeDescribe("Feature", func() {
Context("with context and extra spaces before It block should still pick up Testname", func() {
// Testname: Test with spaces
//Description: Should pick up testname even if it is not within 3 spaces
//even when executed from memory.
framework.ConformanceIt("should work", func() {})
})
})`, []conformanceData{{URL: "https://github.com/kubernetes/kubernetes/tree/master/e2e/foo.go#L8", TestName: "Test with spaces",
Description: `Should pick up testname even if it is not within 3 spaces
even when executed from memory.` + "\n\n"}},
},
} }
func TestConformance(t *testing.T) { func TestConformance(t *testing.T) {