From 7fa1e87d66beafb6e07abe1f5571cc4f2620689a Mon Sep 17 00:00:00 2001 From: Tim Hockin Date: Sat, 25 Jun 2016 01:59:34 +0900 Subject: [PATCH] Simplify convertible check - same type is OK This is to clarify the code. No actual effect at the moment, but I manually verified this in the case of identical types. --- cmd/libs/go2idl/conversion-gen/generators/conversion.go | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/cmd/libs/go2idl/conversion-gen/generators/conversion.go b/cmd/libs/go2idl/conversion-gen/generators/conversion.go index a2a21749b17..5f347f00d3a 100644 --- a/cmd/libs/go2idl/conversion-gen/generators/conversion.go +++ b/cmd/libs/go2idl/conversion-gen/generators/conversion.go @@ -309,6 +309,9 @@ func isDirectlyConvertible(in, out *types.Type, manualConversions conversionFunc return isConvertible(in, out.Underlying, manualConversions) } + if in == out { + return true + } if in.Kind != out.Kind { return false } @@ -318,12 +321,6 @@ func isDirectlyConvertible(in, out *types.Type, manualConversions conversionFunc // We don't support conversion of other types yet. return false } - switch out.Kind { - case types.Builtin, types.Struct, types.Map, types.Slice, types.Pointer: - default: - // We don't support conversion of other types yet. - return false - } switch in.Kind { case types.Builtin: