From 81219ca9d2524176708c28ed34fdb750abc7bdab Mon Sep 17 00:00:00 2001 From: Matthew Fenwick Date: Wed, 2 Sep 2020 21:49:45 -0400 Subject: [PATCH] address review comments --- test/e2e/common/networking.go | 1 - test/e2e/framework/network/utils.go | 3 +-- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/test/e2e/common/networking.go b/test/e2e/common/networking.go index 7d95e8892b3..f08520f9e9d 100644 --- a/test/e2e/common/networking.go +++ b/test/e2e/common/networking.go @@ -52,7 +52,6 @@ var _ = ginkgo.Describe("[sig-network] Networking", func() { framework.Logf("Now attempting to probe pod [[[ %v ]]]", endpointPod.Status.PodIP) if err := config.DialFromTestContainer(protocol, endpointPod.Status.PodIP, port, config.MaxTries, 0, sets.NewString(endpointPod.Name)); err != nil { errors = append(errors, err) - framework.Logf("Warning: Test failure (%v) will occur due to %v", len(errors), err) // convenient error message for diagnosis... how many pods failed, and on what hosts? } else { framework.Logf("Was able to reach %v on %v ", endpointPod.Status.PodIP, endpointPod.Status.HostIP) } diff --git a/test/e2e/framework/network/utils.go b/test/e2e/framework/network/utils.go index ce289f839c1..0ca63f3f6e0 100644 --- a/test/e2e/framework/network/utils.go +++ b/test/e2e/framework/network/utils.go @@ -248,8 +248,7 @@ func makeCURLDialCommand(ipPort, dialCmd, protocol, targetIP string, targetPort // maxTries == minTries will confirm that we see the expected endpoints and no // more for maxTries. Use this if you want to eg: fail a readiness check on a // pod and confirm it doesn't show up as an endpoint. -// -// returns nil if no error, or error message if failed after trying maxTries. +// Returns nil if no error, or error message if failed after trying maxTries. func (config *NetworkingTestConfig) DialFromContainer(protocol, dialCommand, containerIP, targetIP string, containerHTTPPort, targetPort, maxTries, minTries int, expectedResponses sets.String) error { ipPort := net.JoinHostPort(containerIP, strconv.Itoa(containerHTTPPort)) cmd := makeCURLDialCommand(ipPort, dialCommand, protocol, targetIP, targetPort)