Merge pull request #67275 from spiffxp/owners-label-kind-api-change

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Use OWNERS-based labeling for kind/api-change

**What this PR does / why we need it**:

This replaces the following path-label munger config, except
we're using kind/api-change for everything instead of two
different kind/ labels

```
^pkg/api/([^/]+/)?types.go$    kind/api-change
^pkg/api/([^/]+/)?register.go$ kind/new-api
^pkg/apis/[^/]+/([^/]+/)?types.go$    kind/api-change
^pkg/apis/[^/]+/([^/]+/)?register.go$ kind/new-api
```

This fixes https://github.com/kubernetes/test-infra/issues/9007

**Special notes for your reviewer**:
This can be merged independently of us turning path-label off of
mungegithub. While both labeling options are active, they won't
clash, just race. 

```release-note
NONE
```
This commit is contained in:
Kubernetes Submit Queue 2018-08-10 15:19:54 -07:00 committed by GitHub
commit 819253dd2d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 70 additions and 48 deletions

View File

@ -1,4 +1,15 @@
approvers: # See the OWNERS docs at https://go.k8s.io/owners
- api-approvers
reviewers: filters:
- api-reviewers ".*":
approvers:
- api-approvers
reviewers:
- api-reviewers
# examples:
# pkg/api/types.go
# pkg/api/*/register.go
"([^/]+/)?(register|types)\\.go$":
labels:
- kind/api-change

View File

@ -1,44 +1,55 @@
approvers: # See the OWNERS docs at https://go.k8s.io/owners
- erictune
- lavalamp filters:
- smarterclayton ".*":
- thockin approvers:
- liggitt - erictune
# - bgrant0607 # manual escalations only - lavalamp
reviewers: - smarterclayton
- lavalamp - thockin
- smarterclayton - liggitt
- wojtek-t # - bgrant0607 # manual escalations only
- deads2k reviewers:
- yujuhong - lavalamp
- brendandburns - smarterclayton
- derekwaynecarr - wojtek-t
- caesarxuchao - deads2k
- vishh - yujuhong
- mikedanese - brendandburns
- liggitt - derekwaynecarr
- nikhiljindal - caesarxuchao
- gmarek - vishh
- erictune - mikedanese
- pmorie - liggitt
- sttts - nikhiljindal
- dchen1107 - gmarek
- saad-ali - erictune
- luxas - pmorie
- janetkuo - sttts
- justinsb - dchen1107
- pwittrock - saad-ali
- ncdc - luxas
- tallclair - janetkuo
- yifan-gu - justinsb
- eparis - pwittrock
- mwielgus - ncdc
- feiskyer - tallclair
- soltysh - yifan-gu
- piosz - eparis
- dims - mwielgus
- errordeveloper - feiskyer
- madhusudancs - soltysh
- krousey - piosz
- rootfs - dims
- jszczepkowski - errordeveloper
- madhusudancs
- krousey
- rootfs
- jszczepkowski
# examples:
# pkg/apis/*/types.go
# pkg/apis/*/*/types.go
"[^/]+/([^/]+/)?(register|types)\\.go$":
labels:
- kind/api-change