From 81c6989ccc97c045bf4569600022e0b2ad3fef74 Mon Sep 17 00:00:00 2001 From: RainbowMango Date: Mon, 30 Dec 2019 20:29:49 +0800 Subject: [PATCH] Clean up unused variable from unit test. --- staging/src/k8s.io/component-base/metrics/registry_test.go | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/staging/src/k8s.io/component-base/metrics/registry_test.go b/staging/src/k8s.io/component-base/metrics/registry_test.go index 0a6f8dca386..edd9cdb8777 100644 --- a/staging/src/k8s.io/component-base/metrics/registry_test.go +++ b/staging/src/k8s.io/component-base/metrics/registry_test.go @@ -99,7 +99,6 @@ func TestRegister(t *testing.T) { var tests = []struct { desc string metrics []*Counter - registryVersion *semver.Version expectedErrors []error expectedIsCreatedValues []bool expectedIsDeprecated []bool @@ -108,7 +107,6 @@ func TestRegister(t *testing.T) { { desc: "test alpha metric", metrics: []*Counter{alphaCounter}, - registryVersion: &v115, expectedErrors: []error{nil}, expectedIsCreatedValues: []bool{true}, expectedIsDeprecated: []bool{false}, @@ -117,7 +115,6 @@ func TestRegister(t *testing.T) { { desc: "test registering same metric multiple times", metrics: []*Counter{alphaCounter, alphaCounter}, - registryVersion: &v115, expectedErrors: []error{nil, prometheus.AlreadyRegisteredError{}}, expectedIsCreatedValues: []bool{true, true}, expectedIsDeprecated: []bool{false, false}, @@ -126,7 +123,6 @@ func TestRegister(t *testing.T) { { desc: "test alpha deprecated metric", metrics: []*Counter{alphaDeprecatedCounter}, - registryVersion: &v115, expectedErrors: []error{nil}, expectedIsCreatedValues: []bool{true}, expectedIsDeprecated: []bool{true}, @@ -135,7 +131,6 @@ func TestRegister(t *testing.T) { { desc: "test alpha hidden metric", metrics: []*Counter{alphaHiddenCounter}, - registryVersion: &v115, expectedErrors: []error{nil}, expectedIsCreatedValues: []bool{false}, expectedIsDeprecated: []bool{true}, @@ -152,7 +147,7 @@ func TestRegister(t *testing.T) { }) for i, m := range test.metrics { err := registry.Register(m) - if err != test.expectedErrors[i] && err.Error() != test.expectedErrors[i].Error() { + if err != nil && err.Error() != test.expectedErrors[i].Error() { t.Errorf("Got unexpected error %v, wanted %v", err, test.expectedErrors[i]) } if m.IsCreated() != test.expectedIsCreatedValues[i] {