diff --git a/cmd/kubeadm/app/node/BUILD b/cmd/kubeadm/app/node/BUILD index 749e63f1740..9b46ebcfc5b 100644 --- a/cmd/kubeadm/app/node/BUILD +++ b/cmd/kubeadm/app/node/BUILD @@ -46,8 +46,8 @@ go_test( "//pkg/client/clientset_generated/clientset:go_default_library", "//pkg/client/restclient:go_default_library", "//pkg/client/typed/discovery:go_default_library", - "//pkg/version:go_default_library", "//vendor:k8s.io/apimachinery/pkg/apis/meta/v1", + "//vendor:k8s.io/apimachinery/pkg/version", ], ) diff --git a/cmd/kubeadm/app/node/bootstrap_test.go b/cmd/kubeadm/app/node/bootstrap_test.go index ac73975b3dd..01deacb6685 100644 --- a/cmd/kubeadm/app/node/bootstrap_test.go +++ b/cmd/kubeadm/app/node/bootstrap_test.go @@ -23,11 +23,11 @@ import ( "testing" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" + "k8s.io/apimachinery/pkg/version" kubeadmapi "k8s.io/kubernetes/cmd/kubeadm/app/apis/kubeadm" "k8s.io/kubernetes/pkg/client/clientset_generated/clientset" "k8s.io/kubernetes/pkg/client/restclient" "k8s.io/kubernetes/pkg/client/typed/discovery" - "k8s.io/kubernetes/pkg/version" ) func TestEstablishMasterConnection(t *testing.T) { diff --git a/pkg/client/testing/core/BUILD b/pkg/client/testing/core/BUILD index f8d378db85a..b0784aa4511 100644 --- a/pkg/client/testing/core/BUILD +++ b/pkg/client/testing/core/BUILD @@ -28,6 +28,7 @@ go_library( "//vendor:k8s.io/apimachinery/pkg/labels", "//vendor:k8s.io/apimachinery/pkg/runtime", "//vendor:k8s.io/apimachinery/pkg/runtime/schema", + "//vendor:k8s.io/apimachinery/pkg/version", "//vendor:k8s.io/apimachinery/pkg/watch", ], ) diff --git a/pkg/client/testing/core/fake.go b/pkg/client/testing/core/fake.go index 37d1efd3c61..3ec8561525c 100644 --- a/pkg/client/testing/core/fake.go +++ b/pkg/client/testing/core/fake.go @@ -23,9 +23,10 @@ import ( metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" "k8s.io/apimachinery/pkg/runtime" "k8s.io/apimachinery/pkg/runtime/schema" + "k8s.io/apimachinery/pkg/version" "k8s.io/apimachinery/pkg/watch" "k8s.io/kubernetes/pkg/client/restclient" - "k8s.io/kubernetes/pkg/version" + kubeversion "k8s.io/kubernetes/pkg/version" ) // Fake implements client.Interface. Meant to be embedded into a struct to get @@ -253,6 +254,6 @@ func (c *FakeDiscovery) ServerVersion() (*version.Info, error) { action.Resource = schema.GroupVersionResource{Resource: "version"} c.Invokes(action, nil) - versionInfo := version.Get() + versionInfo := kubeversion.Get() return &versionInfo, nil } diff --git a/pkg/client/typed/discovery/BUILD b/pkg/client/typed/discovery/BUILD index 4824499a77c..088997062f5 100644 --- a/pkg/client/typed/discovery/BUILD +++ b/pkg/client/typed/discovery/BUILD @@ -32,6 +32,7 @@ go_library( "//vendor:k8s.io/apimachinery/pkg/runtime/schema", "//vendor:k8s.io/apimachinery/pkg/runtime/serializer", "//vendor:k8s.io/apimachinery/pkg/util/sets", + "//vendor:k8s.io/apimachinery/pkg/version", ], ) @@ -48,13 +49,13 @@ go_test( "//pkg/api/v1:go_default_library", "//pkg/client/restclient:go_default_library", "//pkg/client/restclient/fake:go_default_library", - "//pkg/version:go_default_library", "//vendor:github.com/emicklei/go-restful/swagger", "//vendor:github.com/stretchr/testify/assert", "//vendor:k8s.io/apimachinery/pkg/api/errors", "//vendor:k8s.io/apimachinery/pkg/apis/meta/v1", "//vendor:k8s.io/apimachinery/pkg/runtime/schema", "//vendor:k8s.io/apimachinery/pkg/util/sets", + "//vendor:k8s.io/apimachinery/pkg/version", ], ) diff --git a/pkg/client/typed/discovery/discovery_client.go b/pkg/client/typed/discovery/discovery_client.go index 22fe6294aa2..0565a9b23d8 100644 --- a/pkg/client/typed/discovery/discovery_client.go +++ b/pkg/client/typed/discovery/discovery_client.go @@ -30,10 +30,10 @@ import ( "k8s.io/apimachinery/pkg/runtime" "k8s.io/apimachinery/pkg/runtime/schema" "k8s.io/apimachinery/pkg/runtime/serializer" + "k8s.io/apimachinery/pkg/version" "k8s.io/kubernetes/pkg/api" "k8s.io/kubernetes/pkg/api/v1" "k8s.io/kubernetes/pkg/client/restclient" - "k8s.io/kubernetes/pkg/version" ) // defaultRetries is the number of times a resource discovery is repeated if an api group disappears on the fly (e.g. ThirdPartyResources). diff --git a/pkg/client/typed/discovery/discovery_client_test.go b/pkg/client/typed/discovery/discovery_client_test.go index 1f1886fb6f7..80d72f0c641 100644 --- a/pkg/client/typed/discovery/discovery_client_test.go +++ b/pkg/client/typed/discovery/discovery_client_test.go @@ -28,9 +28,9 @@ import ( metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" "k8s.io/apimachinery/pkg/runtime/schema" "k8s.io/apimachinery/pkg/util/sets" + "k8s.io/apimachinery/pkg/version" "k8s.io/kubernetes/pkg/api/v1" "k8s.io/kubernetes/pkg/client/restclient" - "k8s.io/kubernetes/pkg/version" ) func TestGetServerVersion(t *testing.T) { diff --git a/pkg/client/typed/discovery/fake/BUILD b/pkg/client/typed/discovery/fake/BUILD index 9bf05c7880f..25898989978 100644 --- a/pkg/client/typed/discovery/fake/BUILD +++ b/pkg/client/typed/discovery/fake/BUILD @@ -19,6 +19,7 @@ go_library( "//vendor:github.com/emicklei/go-restful/swagger", "//vendor:k8s.io/apimachinery/pkg/apis/meta/v1", "//vendor:k8s.io/apimachinery/pkg/runtime/schema", + "//vendor:k8s.io/apimachinery/pkg/version", ], ) diff --git a/pkg/client/typed/discovery/fake/discovery.go b/pkg/client/typed/discovery/fake/discovery.go index c38f9edf4fb..b1de695280a 100644 --- a/pkg/client/typed/discovery/fake/discovery.go +++ b/pkg/client/typed/discovery/fake/discovery.go @@ -23,10 +23,11 @@ import ( metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" "k8s.io/apimachinery/pkg/runtime/schema" + "k8s.io/apimachinery/pkg/version" "k8s.io/kubernetes/pkg/api/v1" "k8s.io/kubernetes/pkg/client/restclient" "k8s.io/kubernetes/pkg/client/testing/core" - "k8s.io/kubernetes/pkg/version" + kubeversion "k8s.io/kubernetes/pkg/version" ) type FakeDiscovery struct { @@ -74,7 +75,7 @@ func (c *FakeDiscovery) ServerVersion() (*version.Info, error) { action.Resource = schema.GroupVersionResource{Resource: "version"} c.Invokes(action, nil) - versionInfo := version.Get() + versionInfo := kubeversion.Get() return &versionInfo, nil } diff --git a/pkg/client/typed/discovery/restmapper_test.go b/pkg/client/typed/discovery/restmapper_test.go index 40c32e254c6..39b4afdc5a2 100644 --- a/pkg/client/typed/discovery/restmapper_test.go +++ b/pkg/client/typed/discovery/restmapper_test.go @@ -23,10 +23,10 @@ import ( "k8s.io/apimachinery/pkg/api/errors" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" "k8s.io/apimachinery/pkg/runtime/schema" + "k8s.io/apimachinery/pkg/version" "k8s.io/kubernetes/pkg/api" "k8s.io/kubernetes/pkg/client/restclient" "k8s.io/kubernetes/pkg/client/restclient/fake" - "k8s.io/kubernetes/pkg/version" "github.com/emicklei/go-restful/swagger" "github.com/stretchr/testify/assert" diff --git a/pkg/genericapiserver/BUILD b/pkg/genericapiserver/BUILD index 1bc76baa555..92df56a7632 100644 --- a/pkg/genericapiserver/BUILD +++ b/pkg/genericapiserver/BUILD @@ -8,6 +8,47 @@ load( "go_test", ) +go_test( + name = "go_default_test", + srcs = [ + "genericapiserver_test.go", + "resource_config_test.go", + "serve_test.go", + "server_run_options_test.go", + "storage_factory_test.go", + ], + library = ":go_default_library", + tags = ["automanaged"], + deps = [ + "//pkg/api:go_default_library", + "//pkg/api/testapi:go_default_library", + "//pkg/api/v1:go_default_library", + "//pkg/apis/autoscaling:go_default_library", + "//pkg/apis/extensions:go_default_library", + "//pkg/client/clientset_generated/clientset:go_default_library", + "//pkg/generated/openapi:go_default_library", + "//pkg/genericapiserver/api/rest:go_default_library", + "//pkg/genericapiserver/options:go_default_library", + "//pkg/storage/etcd/testing:go_default_library", + "//pkg/storage/storagebackend:go_default_library", + "//pkg/util/cert:go_default_library", + "//pkg/util/config:go_default_library", + "//vendor:github.com/go-openapi/spec", + "//vendor:github.com/stretchr/testify/assert", + "//vendor:k8s.io/apimachinery/pkg/api/meta", + "//vendor:k8s.io/apimachinery/pkg/apimachinery", + "//vendor:k8s.io/apimachinery/pkg/apis/meta/v1", + "//vendor:k8s.io/apimachinery/pkg/runtime", + "//vendor:k8s.io/apimachinery/pkg/runtime/schema", + "//vendor:k8s.io/apimachinery/pkg/util/net", + "//vendor:k8s.io/apimachinery/pkg/util/sets", + "//vendor:k8s.io/apimachinery/pkg/version", + "//vendor:k8s.io/apiserver/pkg/authentication/user", + "//vendor:k8s.io/apiserver/pkg/authorization/authorizer", + "//vendor:k8s.io/apiserver/pkg/request", + ], +) + go_library( name = "go_default_library", srcs = [ @@ -41,7 +82,6 @@ go_library( "//pkg/genericapiserver/routes:go_default_library", "//pkg/storage/storagebackend:go_default_library", "//pkg/util/cert:go_default_library", - "//pkg/version:go_default_library", "//vendor:github.com/coreos/go-systemd/daemon", "//vendor:github.com/emicklei/go-restful", "//vendor:github.com/emicklei/go-restful/swagger", @@ -60,6 +100,7 @@ go_library( "//vendor:k8s.io/apimachinery/pkg/util/runtime", "//vendor:k8s.io/apimachinery/pkg/util/sets", "//vendor:k8s.io/apimachinery/pkg/util/validation", + "//vendor:k8s.io/apimachinery/pkg/version", "//vendor:k8s.io/apiserver/pkg/authentication/authenticator", "//vendor:k8s.io/apiserver/pkg/authentication/request/union", "//vendor:k8s.io/apiserver/pkg/authentication/user", @@ -70,47 +111,6 @@ go_library( ], ) -go_test( - name = "go_default_test", - srcs = [ - "genericapiserver_test.go", - "resource_config_test.go", - "serve_test.go", - "server_run_options_test.go", - "storage_factory_test.go", - ], - library = ":go_default_library", - tags = ["automanaged"], - deps = [ - "//pkg/api:go_default_library", - "//pkg/api/testapi:go_default_library", - "//pkg/api/v1:go_default_library", - "//pkg/apis/autoscaling:go_default_library", - "//pkg/apis/extensions:go_default_library", - "//pkg/client/clientset_generated/clientset:go_default_library", - "//pkg/generated/openapi:go_default_library", - "//pkg/genericapiserver/api/rest:go_default_library", - "//pkg/genericapiserver/options:go_default_library", - "//pkg/storage/etcd/testing:go_default_library", - "//pkg/storage/storagebackend:go_default_library", - "//pkg/util/cert:go_default_library", - "//pkg/util/config:go_default_library", - "//pkg/version:go_default_library", - "//vendor:github.com/go-openapi/spec", - "//vendor:github.com/stretchr/testify/assert", - "//vendor:k8s.io/apimachinery/pkg/api/meta", - "//vendor:k8s.io/apimachinery/pkg/apimachinery", - "//vendor:k8s.io/apimachinery/pkg/apis/meta/v1", - "//vendor:k8s.io/apimachinery/pkg/runtime", - "//vendor:k8s.io/apimachinery/pkg/runtime/schema", - "//vendor:k8s.io/apimachinery/pkg/util/net", - "//vendor:k8s.io/apimachinery/pkg/util/sets", - "//vendor:k8s.io/apiserver/pkg/authentication/user", - "//vendor:k8s.io/apiserver/pkg/authorization/authorizer", - "//vendor:k8s.io/apiserver/pkg/request", - ], -) - filegroup( name = "package-srcs", srcs = glob(["**"]), diff --git a/pkg/genericapiserver/config.go b/pkg/genericapiserver/config.go index 18d554da886..91fd37eb6f4 100644 --- a/pkg/genericapiserver/config.go +++ b/pkg/genericapiserver/config.go @@ -40,6 +40,7 @@ import ( openapicommon "k8s.io/apimachinery/pkg/openapi" "k8s.io/apimachinery/pkg/runtime" "k8s.io/apimachinery/pkg/util/sets" + "k8s.io/apimachinery/pkg/version" "k8s.io/apiserver/pkg/authentication/authenticator" authenticatorunion "k8s.io/apiserver/pkg/authentication/request/union" "k8s.io/apiserver/pkg/authentication/user" @@ -60,7 +61,6 @@ import ( "k8s.io/kubernetes/pkg/genericapiserver/options" "k8s.io/kubernetes/pkg/genericapiserver/routes" certutil "k8s.io/kubernetes/pkg/util/cert" - "k8s.io/kubernetes/pkg/version" ) const ( diff --git a/pkg/genericapiserver/genericapiserver_test.go b/pkg/genericapiserver/genericapiserver_test.go index 1046653b7e6..a0b9133cef4 100644 --- a/pkg/genericapiserver/genericapiserver_test.go +++ b/pkg/genericapiserver/genericapiserver_test.go @@ -25,7 +25,12 @@ import ( "net/http" "net/http/httptest" "reflect" + goruntime "runtime" "testing" + "time" + + "github.com/go-openapi/spec" + "github.com/stretchr/testify/assert" "k8s.io/apimachinery/pkg/api/meta" "k8s.io/apimachinery/pkg/apimachinery" @@ -34,6 +39,7 @@ import ( "k8s.io/apimachinery/pkg/runtime/schema" utilnet "k8s.io/apimachinery/pkg/util/net" "k8s.io/apimachinery/pkg/util/sets" + "k8s.io/apimachinery/pkg/version" "k8s.io/apiserver/pkg/authentication/user" "k8s.io/apiserver/pkg/authorization/authorizer" genericapirequest "k8s.io/apiserver/pkg/request" @@ -44,10 +50,6 @@ import ( openapigen "k8s.io/kubernetes/pkg/generated/openapi" "k8s.io/kubernetes/pkg/genericapiserver/api/rest" etcdtesting "k8s.io/kubernetes/pkg/storage/etcd/testing" - "k8s.io/kubernetes/pkg/version" - - "github.com/go-openapi/spec" - "github.com/stretchr/testify/assert" ) // setUp is a convience function for setting up for (most) tests. @@ -372,7 +374,7 @@ func TestNotRestRoutesHaveAuth(t *testing.T) { config.EnableProfiling = true config.SwaggerConfig = DefaultSwaggerConfig() - kubeVersion := version.Get() + kubeVersion := fakeVersion() config.Version = &kubeVersion s, err := config.SkipComplete().New() @@ -618,3 +620,17 @@ func (p *testNoVerbsStorage) New() runtime.Object { }, } } + +func fakeVersion() version.Info { + return version.Info{ + Major: "42", + Minor: "42", + GitVersion: "42", + GitCommit: "34973274ccef6ab4dfaaf86599792fa9c3fe4689", + GitTreeState: "Dirty", + BuildDate: time.Now().String(), + GoVersion: goruntime.Version(), + Compiler: goruntime.Compiler, + Platform: fmt.Sprintf("%s/%s", goruntime.GOOS, goruntime.GOARCH), + } +} diff --git a/pkg/genericapiserver/routes/BUILD b/pkg/genericapiserver/routes/BUILD index 6ddbbe23346..621a2d14c14 100644 --- a/pkg/genericapiserver/routes/BUILD +++ b/pkg/genericapiserver/routes/BUILD @@ -25,7 +25,6 @@ go_library( "//pkg/genericapiserver/mux:go_default_library", "//pkg/genericapiserver/openapi:go_default_library", "//pkg/genericapiserver/routes/data/swagger:go_default_library", - "//pkg/version:go_default_library", "//vendor:github.com/elazarl/go-bindata-assetfs", "//vendor:github.com/emicklei/go-restful", "//vendor:github.com/emicklei/go-restful/swagger", @@ -33,6 +32,7 @@ go_library( "//vendor:github.com/prometheus/client_golang/prometheus", "//vendor:k8s.io/apimachinery/pkg/apis/meta/v1", "//vendor:k8s.io/apimachinery/pkg/openapi", + "//vendor:k8s.io/apimachinery/pkg/version", "//vendor:k8s.io/apiserver/pkg/metrics", "//vendor:k8s.io/apiserver/pkg/storage/etcd/metrics", ], diff --git a/pkg/genericapiserver/routes/version.go b/pkg/genericapiserver/routes/version.go index 76d5504275a..a0ecc643b6d 100644 --- a/pkg/genericapiserver/routes/version.go +++ b/pkg/genericapiserver/routes/version.go @@ -21,9 +21,9 @@ import ( "github.com/emicklei/go-restful" + "k8s.io/apimachinery/pkg/version" "k8s.io/kubernetes/pkg/genericapiserver/api/handlers/responsewriters" "k8s.io/kubernetes/pkg/genericapiserver/mux" - "k8s.io/kubernetes/pkg/version" ) // Version provides a webservice with version information. diff --git a/pkg/genericapiserver/serve_test.go b/pkg/genericapiserver/serve_test.go index e3fb6bb759f..de2d94591e1 100644 --- a/pkg/genericapiserver/serve_test.go +++ b/pkg/genericapiserver/serve_test.go @@ -35,7 +35,6 @@ import ( "k8s.io/kubernetes/pkg/genericapiserver/options" utilcert "k8s.io/kubernetes/pkg/util/cert" "k8s.io/kubernetes/pkg/util/config" - "k8s.io/kubernetes/pkg/version" ) type TestCertSpec struct { @@ -465,7 +464,7 @@ NextTest: etcdserver, config, _ := setUp(t) defer etcdserver.Terminate(t) - v := version.Get() + v := fakeVersion() config.Version = &v config.EnableIndex = true diff --git a/pkg/kubectl/cmd/util/BUILD b/pkg/kubectl/cmd/util/BUILD index 3c86b204990..81247da7a65 100644 --- a/pkg/kubectl/cmd/util/BUILD +++ b/pkg/kubectl/cmd/util/BUILD @@ -47,7 +47,6 @@ go_library( "//pkg/util/flag:go_default_library", "//pkg/util/homedir:go_default_library", "//pkg/util/strategicpatch:go_default_library", - "//pkg/version:go_default_library", "//vendor:github.com/emicklei/go-restful/swagger", "//vendor:github.com/evanphx/json-patch", "//vendor:github.com/golang/glog", @@ -63,6 +62,7 @@ go_library( "//vendor:k8s.io/apimachinery/pkg/runtime/serializer/json", "//vendor:k8s.io/apimachinery/pkg/util/errors", "//vendor:k8s.io/apimachinery/pkg/util/sets", + "//vendor:k8s.io/apimachinery/pkg/version", "//vendor:k8s.io/apimachinery/pkg/watch", ], ) @@ -99,7 +99,6 @@ go_test( "//pkg/kubectl/resource:go_default_library", "//pkg/util/exec:go_default_library", "//pkg/util/flag:go_default_library", - "//pkg/version:go_default_library", "//vendor:github.com/emicklei/go-restful/swagger", "//vendor:github.com/stretchr/testify/assert", "//vendor:k8s.io/apimachinery/pkg/api/errors", @@ -109,6 +108,7 @@ go_test( "//vendor:k8s.io/apimachinery/pkg/runtime", "//vendor:k8s.io/apimachinery/pkg/runtime/schema", "//vendor:k8s.io/apimachinery/pkg/util/validation/field", + "//vendor:k8s.io/apimachinery/pkg/version", "//vendor:k8s.io/apimachinery/pkg/watch", ], ) diff --git a/pkg/kubectl/cmd/util/cached_discovery.go b/pkg/kubectl/cmd/util/cached_discovery.go index 1a781caae27..c38e0d6d7cc 100644 --- a/pkg/kubectl/cmd/util/cached_discovery.go +++ b/pkg/kubectl/cmd/util/cached_discovery.go @@ -30,10 +30,10 @@ import ( metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" "k8s.io/apimachinery/pkg/runtime" "k8s.io/apimachinery/pkg/runtime/schema" + "k8s.io/apimachinery/pkg/version" "k8s.io/kubernetes/pkg/api" "k8s.io/kubernetes/pkg/client/restclient" "k8s.io/kubernetes/pkg/client/typed/discovery" - "k8s.io/kubernetes/pkg/version" ) // CachedDiscoveryClient implements the functions that discovery server-supported API groups, diff --git a/pkg/kubectl/cmd/util/cached_discovery_test.go b/pkg/kubectl/cmd/util/cached_discovery_test.go index ff1caa21f09..747e2a0970b 100644 --- a/pkg/kubectl/cmd/util/cached_discovery_test.go +++ b/pkg/kubectl/cmd/util/cached_discovery_test.go @@ -28,10 +28,10 @@ import ( "k8s.io/apimachinery/pkg/api/errors" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" "k8s.io/apimachinery/pkg/runtime/schema" + "k8s.io/apimachinery/pkg/version" "k8s.io/kubernetes/pkg/client/restclient" "k8s.io/kubernetes/pkg/client/restclient/fake" "k8s.io/kubernetes/pkg/client/typed/discovery" - "k8s.io/kubernetes/pkg/version" ) func TestCachedDiscoveryClient_Fresh(t *testing.T) { diff --git a/pkg/master/BUILD b/pkg/master/BUILD index fcbc8c4360d..8d979e54a55 100644 --- a/pkg/master/BUILD +++ b/pkg/master/BUILD @@ -130,6 +130,7 @@ go_test( "//vendor:k8s.io/apimachinery/pkg/runtime/schema", "//vendor:k8s.io/apimachinery/pkg/util/net", "//vendor:k8s.io/apimachinery/pkg/util/sets", + "//vendor:k8s.io/apimachinery/pkg/version", "//vendor:k8s.io/apiserver/pkg/request", ], ) diff --git a/pkg/master/master_test.go b/pkg/master/master_test.go index 8941bda8465..6dc4ba9f844 100644 --- a/pkg/master/master_test.go +++ b/pkg/master/master_test.go @@ -31,6 +31,7 @@ import ( "k8s.io/apimachinery/pkg/runtime/schema" utilnet "k8s.io/apimachinery/pkg/util/net" "k8s.io/apimachinery/pkg/util/sets" + "k8s.io/apimachinery/pkg/version" genericapirequest "k8s.io/apiserver/pkg/request" "k8s.io/kubernetes/pkg/api" "k8s.io/kubernetes/pkg/api/testapi" @@ -51,7 +52,7 @@ import ( "k8s.io/kubernetes/pkg/genericapiserver" kubeletclient "k8s.io/kubernetes/pkg/kubelet/client" etcdtesting "k8s.io/kubernetes/pkg/storage/etcd/testing" - "k8s.io/kubernetes/pkg/version" + kubeversion "k8s.io/kubernetes/pkg/version" "github.com/stretchr/testify/assert" ) @@ -77,7 +78,7 @@ func setUp(t *testing.T) (*Master, *etcdtesting.EtcdTestServer, Config, *assert. resourceEncoding.SetVersionEncoding(certificates.GroupName, *testapi.Certificates.GroupVersion(), schema.GroupVersion{Group: certificates.GroupName, Version: runtime.APIVersionInternal}) storageFactory := genericapiserver.NewDefaultStorageFactory(*storageConfig, testapi.StorageMediaType(), api.Codecs, resourceEncoding, DefaultAPIResourceConfigSource()) - kubeVersion := version.Get() + kubeVersion := kubeversion.Get() config.GenericConfig.Version = &kubeVersion config.StorageFactory = storageFactory config.GenericConfig.LoopbackClientConfig = &restclient.Config{APIPath: "/api", ContentConfig: restclient.ContentConfig{NegotiatedSerializer: api.Codecs}} @@ -156,8 +157,8 @@ func TestVersion(t *testing.T) { t.Errorf("unexpected error: %v", err) } - if !reflect.DeepEqual(version.Get(), info) { - t.Errorf("Expected %#v, Got %#v", version.Get(), info) + if !reflect.DeepEqual(kubeversion.Get(), info) { + t.Errorf("Expected %#v, Got %#v", kubeversion.Get(), info) } } diff --git a/pkg/version/BUILD b/pkg/version/BUILD index d9de60d99a6..00216c5e914 100644 --- a/pkg/version/BUILD +++ b/pkg/version/BUILD @@ -15,6 +15,7 @@ go_library( "version.go", ], tags = ["automanaged"], + deps = ["//vendor:k8s.io/apimachinery/pkg/version"], ) filegroup( diff --git a/pkg/version/verflag/verflag.go b/pkg/version/verflag/verflag.go index d1f08da0692..5809c3aa8f4 100644 --- a/pkg/version/verflag/verflag.go +++ b/pkg/version/verflag/verflag.go @@ -24,6 +24,7 @@ import ( "strconv" flag "github.com/spf13/pflag" + "k8s.io/kubernetes/pkg/version" ) diff --git a/pkg/version/version.go b/pkg/version/version.go index 0da3aadde07..8c8350d13b7 100644 --- a/pkg/version/version.go +++ b/pkg/version/version.go @@ -19,29 +19,16 @@ package version import ( "fmt" "runtime" -) -// Info contains versioning information. -// TODO: Add []string of api versions supported? It's still unclear -// how we'll want to distribute that information. -type Info struct { - Major string `json:"major"` - Minor string `json:"minor"` - GitVersion string `json:"gitVersion"` - GitCommit string `json:"gitCommit"` - GitTreeState string `json:"gitTreeState"` - BuildDate string `json:"buildDate"` - GoVersion string `json:"goVersion"` - Compiler string `json:"compiler"` - Platform string `json:"platform"` -} + apimachineryversion "k8s.io/apimachinery/pkg/version" +) // Get returns the overall codebase version. It's for detecting // what code a binary was built from. -func Get() Info { +func Get() apimachineryversion.Info { // These variables typically come from -ldflags settings and in // their absence fallback to the settings in pkg/version/base.go - return Info{ + return apimachineryversion.Info{ Major: gitMajor, Minor: gitMinor, GitVersion: gitVersion, @@ -53,8 +40,3 @@ func Get() Info { Platform: fmt.Sprintf("%s/%s", runtime.GOOS, runtime.GOARCH), } } - -// String returns info as a human-friendly version string. -func (info Info) String() string { - return info.GitVersion -} diff --git a/staging/src/k8s.io/apimachinery/pkg/version/doc.go b/staging/src/k8s.io/apimachinery/pkg/version/doc.go new file mode 100644 index 00000000000..5e77af7ea9a --- /dev/null +++ b/staging/src/k8s.io/apimachinery/pkg/version/doc.go @@ -0,0 +1,19 @@ +/* +Copyright 2014 The Kubernetes Authors. + +Licensed under the Apache License, Version 2.0 (the "License"); +you may not use this file except in compliance with the License. +You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +*/ + +// Package version supplies the type for version information collected at build time. +// +k8s:openapi-gen=true +package version // import "k8s.io/apimachinery/pkg/version" diff --git a/staging/src/k8s.io/apimachinery/pkg/version/types.go b/staging/src/k8s.io/apimachinery/pkg/version/types.go new file mode 100644 index 00000000000..72727b503b7 --- /dev/null +++ b/staging/src/k8s.io/apimachinery/pkg/version/types.go @@ -0,0 +1,37 @@ +/* +Copyright 2014 The Kubernetes Authors. + +Licensed under the Apache License, Version 2.0 (the "License"); +you may not use this file except in compliance with the License. +You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +*/ + +package version + +// Info contains versioning information. +// TODO: Add []string of api versions supported? It's still unclear +// how we'll want to distribute that information. +type Info struct { + Major string `json:"major"` + Minor string `json:"minor"` + GitVersion string `json:"gitVersion"` + GitCommit string `json:"gitCommit"` + GitTreeState string `json:"gitTreeState"` + BuildDate string `json:"buildDate"` + GoVersion string `json:"goVersion"` + Compiler string `json:"compiler"` + Platform string `json:"platform"` +} + +// String returns info as a human-friendly version string. +func (info Info) String() string { + return info.GitVersion +} diff --git a/vendor/BUILD b/vendor/BUILD index 0164de92aa8..f9e647af520 100644 --- a/vendor/BUILD +++ b/vendor/BUILD @@ -7845,6 +7845,19 @@ go_library( ], ) +go_library( + name = "k8s.io/apimachinery/pkg/api/validation", + srcs = [ + "k8s.io/apimachinery/pkg/api/validation/doc.go", + "k8s.io/apimachinery/pkg/api/validation/generic.go", + ], + tags = ["automanaged"], + deps = [ + "//vendor:k8s.io/apimachinery/pkg/util/validation", + "//vendor:k8s.io/apimachinery/pkg/util/validation/field", + ], +) + go_test( name = "k8s.io/apimachinery/pkg/apimachinery_test", srcs = ["k8s.io/apimachinery/pkg/apimachinery/types_test.go"], @@ -8542,6 +8555,15 @@ go_library( ], ) +go_library( + name = "k8s.io/apimachinery/pkg/version", + srcs = [ + "k8s.io/apimachinery/pkg/version/doc.go", + "k8s.io/apimachinery/pkg/version/types.go", + ], + tags = ["automanaged"], +) + go_library( name = "k8s.io/apimachinery/pkg/watch", srcs = [ @@ -13382,16 +13404,3 @@ filegroup( srcs = [":package-srcs"], tags = ["automanaged"], ) - -go_library( - name = "k8s.io/apimachinery/pkg/api/validation", - srcs = [ - "k8s.io/apimachinery/pkg/api/validation/doc.go", - "k8s.io/apimachinery/pkg/api/validation/generic.go", - ], - tags = ["automanaged"], - deps = [ - "//vendor:k8s.io/apimachinery/pkg/util/validation", - "//vendor:k8s.io/apimachinery/pkg/util/validation/field", - ], -)