From f0e74bfb7ff797da7496419f828e528c5789e96a Mon Sep 17 00:00:00 2001 From: sunzhaochang Date: Fri, 10 Dec 2021 20:07:37 +0800 Subject: [PATCH] Fix unexpected end of TestDependentsRace --- pkg/controller/garbagecollector/garbagecollector_test.go | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/pkg/controller/garbagecollector/garbagecollector_test.go b/pkg/controller/garbagecollector/garbagecollector_test.go index 64b3f0faccc..f5af03c94f1 100644 --- a/pkg/controller/garbagecollector/garbagecollector_test.go +++ b/pkg/controller/garbagecollector/garbagecollector_test.go @@ -446,7 +446,10 @@ func TestDependentsRace(t *testing.T) { owner := &node{dependents: make(map[*node]struct{})} ownerUID := types.UID("owner") gc.dependencyGraphBuilder.uidToNode.Write(owner) + var wg sync.WaitGroup + wg.Add(2) go func() { + defer wg.Done() for i := 0; i < updates; i++ { dependent := &node{} gc.dependencyGraphBuilder.addDependentToOwners(dependent, []metav1.OwnerReference{{UID: ownerUID}}) @@ -454,11 +457,13 @@ func TestDependentsRace(t *testing.T) { } }() go func() { - gc.attemptToOrphan.Add(owner) + defer wg.Done() for i := 0; i < updates; i++ { + gc.attemptToOrphan.Add(owner) gc.attemptToOrphanWorker() } }() + wg.Wait() } func podToGCNode(pod *v1.Pod) *node {