github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-29 14:37:00 +00:00
Code Issues Projects Releases Wiki Activity

apiextensions: document that webhook conversion requires preserveUnknownFields=false

Browse Source
This commit is contained in:
Dr. Stefan Schimanski 2019-05-28 12:17:53 +02:00
parent 333f6391ed
commit 83322bd928
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
staging/src/k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/types.go
View File

@ -85,7 +85,8 @@ type CustomResourceDefinitionSpec struct {
type CustomResourceConversion struct { type CustomResourceConversion struct {
// `strategy` specifies the conversion strategy. Allowed values are: // `strategy` specifies the conversion strategy. Allowed values are:
// - `None`: The converter only change the apiVersion and would not touch any other field in the CR. // - `None`: The converter only change the apiVersion and would not touch any other field in the CR.
// - `Webhook`: API Server will call to an external webhook to do the conversion. Additional information is needed for this option. // - `Webhook`: API Server will call to an external webhook to do the conversion. Additional information
// is needed for this option. This requires spec.preserveUnknownFields to be false.
Strategy ConversionStrategyType Strategy ConversionStrategyType
// `webhookClientConfig` is the instructions for how to call the webhook if strategy is `Webhook`. // `webhookClientConfig` is the instructions for how to call the webhook if strategy is `Webhook`.

3
staging/src/k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1beta1/types.go
View File

@ -90,7 +90,8 @@ type CustomResourceDefinitionSpec struct {
type CustomResourceConversion struct { type CustomResourceConversion struct {
// `strategy` specifies the conversion strategy. Allowed values are: // `strategy` specifies the conversion strategy. Allowed values are:
// - `None`: The converter only change the apiVersion and would not touch any other field in the CR. // - `None`: The converter only change the apiVersion and would not touch any other field in the CR.
// - `Webhook`: API Server will call to an external webhook to do the conversion. Additional information is needed for this option. // - `Webhook`: API Server will call to an external webhook to do the conversion. Additional information
// is needed for this option. This requires spec.preserveUnknownFields to be false.
Strategy ConversionStrategyType `json:"strategy" protobuf:"bytes,1,name=strategy"` Strategy ConversionStrategyType `json:"strategy" protobuf:"bytes,1,name=strategy"`
// `webhookClientConfig` is the instructions for how to call the webhook if strategy is `Webhook`. This field is // `webhookClientConfig` is the instructions for how to call the webhook if strategy is `Webhook`. This field is