From 83751630081e5180b633aea7560d689246780582 Mon Sep 17 00:00:00 2001 From: Maksym Pavlenko Date: Wed, 21 Feb 2024 12:56:13 -0800 Subject: [PATCH] Add test to validate non empty pod log dir Signed-off-by: Maksym Pavlenko --- pkg/kubelet/apis/config/validation/validation_test.go | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/pkg/kubelet/apis/config/validation/validation_test.go b/pkg/kubelet/apis/config/validation/validation_test.go index 8605fbb49d8..38b296f5508 100644 --- a/pkg/kubelet/apis/config/validation/validation_test.go +++ b/pkg/kubelet/apis/config/validation/validation_test.go @@ -569,6 +569,13 @@ func TestValidateKubeletConfiguration(t *testing.T) { return conf }, errMsg: "invalid configuration: containerLogMonitorInterval must be a positive time duration greater than or equal to 3s", + }, { + name: "pod logs path must be not empty", + configure: func(config *kubeletconfig.KubeletConfiguration) *kubeletconfig.KubeletConfiguration { + config.PodLogsDir = "" + return config + }, + errMsg: "invalid configuration: podLogsDir was not specified", }, { name: "pod logs path must be absolute", configure: func(config *kubeletconfig.KubeletConfiguration) *kubeletconfig.KubeletConfiguration {