From 8448b60f514cb390956a63f26b93c77993f8edcc Mon Sep 17 00:00:00 2001 From: Clayton Coleman Date: Thu, 28 Jan 2016 00:15:44 -0500 Subject: [PATCH] Kubelet server was not returning a 500 on errors writing logs Writing 200 first masks the second error. 200 is defaulted by the Go http stack automatically. --- pkg/kubelet/server/server.go | 1 - 1 file changed, 1 deletion(-) diff --git a/pkg/kubelet/server/server.go b/pkg/kubelet/server/server.go index 0f61d40b426..c9cab66ed35 100644 --- a/pkg/kubelet/server/server.go +++ b/pkg/kubelet/server/server.go @@ -440,7 +440,6 @@ func (s *Server) getContainerLogs(request *restful.Request, response *restful.Re fw = limitwriter.New(fw, *logOptions.LimitBytes) } response.Header().Set("Transfer-Encoding", "chunked") - response.WriteHeader(http.StatusOK) if err := s.host.GetKubeletContainerLogs(kubecontainer.GetPodFullName(pod), containerName, logOptions, fw, fw); err != nil { if err != limitwriter.ErrMaximumWrite { response.WriteError(http.StatusInternalServerError, err)