From 847ae378ef170c6eb7e9d5babdb9dc7d2b81ea0c Mon Sep 17 00:00:00 2001 From: Barni S Date: Thu, 15 Oct 2020 16:17:14 -0400 Subject: [PATCH] Fix windows node startup failures. 1. cd to root dir before removing temp installer path. It was failing because we were trying to remove while being in the same dir. 2. Expand variables in a regular string and use it in the command. Expansion was failing in single quotes. --- cluster/gce/windows/k8s-node-setup.psm1 | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/cluster/gce/windows/k8s-node-setup.psm1 b/cluster/gce/windows/k8s-node-setup.psm1 index 845990521b0..e93298aeb57 100644 --- a/cluster/gce/windows/k8s-node-setup.psm1 +++ b/cluster/gce/windows/k8s-node-setup.psm1 @@ -1627,16 +1627,17 @@ function DownloadAndInstall-LoggingAgents { Log-Output 'Extracting Logging agent' Expand-Archive td.zip mv .\td\td-agent-bit-${LOGGINGAGENT_VERSION}-win64\ $LOGGINGAGENT_ROOT + cd C:\ Remove-Item -Force -Recurse $install_dir } # Download Logging exporter if needed if (ShouldWrite-File $LOGGINGEXPORTER_ROOT\flb-exporter.exe) { + $url = ("https://storage.googleapis.com/gke-release/winnode/fluentbit-exporter/${LOGGINGEXPORTER_VERSION}/flb-exporter-${LOGGINGEXPORTER_VERSION}.exe") Log-Output 'Downloading logging exporter' New-Item $LOGGINGEXPORTER_ROOT -ItemType 'directory' -Force | Out-Null MustDownload-File ` - -OutFile $LOGGINGEXPORTER_ROOT\flb-exporter.exe ` - -URLs 'https://storage.googleapis.com/gke-release/winnode/fluentbit-exporter/${LOGGINGEXPORTER_VERSION}/flb-exporter-${LOGGINGEXPORTER_VERSION}.exe' + -OutFile $LOGGINGEXPORTER_ROOT\flb-exporter.exe -URLs $url } }