From 84dfaace5d0c26bf4e4ccd05297c9acb8aa00ddf Mon Sep 17 00:00:00 2001 From: Indeed Date: Mon, 4 May 2020 10:57:01 -0700 Subject: [PATCH] add test about shutdown but non-existing node. --- .../cloud/node_lifecycle_controller_test.go | 31 +++++++++++++++++++ 1 file changed, 31 insertions(+) diff --git a/pkg/controller/cloud/node_lifecycle_controller_test.go b/pkg/controller/cloud/node_lifecycle_controller_test.go index 974daea95bc..9db1cfd4505 100644 --- a/pkg/controller/cloud/node_lifecycle_controller_test.go +++ b/pkg/controller/cloud/node_lifecycle_controller_test.go @@ -416,6 +416,37 @@ func Test_NodesShutdown(t *testing.T) { }, updatedNodes: []*v1.Node{}, }, + { + name: "node is shutdown but provider says it does not exist", + fnh: &testutil.FakeNodeHandler{ + Existing: []*v1.Node{ + { + ObjectMeta: metav1.ObjectMeta{ + Name: "node0", + CreationTimestamp: metav1.Date(2012, 1, 1, 0, 0, 0, 0, time.Local), + }, + Status: v1.NodeStatus{ + Conditions: []v1.NodeCondition{ + { + Type: v1.NodeReady, + Status: v1.ConditionUnknown, + LastHeartbeatTime: metav1.Date(2015, 1, 1, 12, 0, 0, 0, time.Local), + LastTransitionTime: metav1.Date(2015, 1, 1, 12, 0, 0, 0, time.Local), + }, + }, + }, + }, + }, + Clientset: fake.NewSimpleClientset(), + UpdatedNodes: []*v1.Node{}, + }, + fakeCloud: &fakecloud.Cloud{ + NodeShutdown: true, + ExistsByProviderID: false, + ErrShutdownByProviderID: nil, + }, + updatedNodes: []*v1.Node{}, // should be empty because node does not exist + }, } for _, testcase := range testcases {