github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-24 12:15:52 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #79906 from tedyu/az-new-http

Browse Source 
Handle error return from http.NewRequest()
This commit is contained in:
Kubernetes Prow Robot 2019-07-09 04:20:04 -07:00 committed by GitHub
commit 84e5b851de
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
pkg/credentialprovider/azure/azure_acr_helper.go
View File

@ -84,7 +84,10 @@ func receiveChallengeFromLoginServer(serverAddress string) (*authDirective, erro
}
var err error
var r *http.Request
r, _ = http.NewRequest("GET", challengeURL.String(), nil)
r, err = http.NewRequest("GET", challengeURL.String(), nil)
if err != nil {
return nil, fmt.Errorf("failed to construct request, got %v", err)
}
r.Header.Add(userAgentHeader, userAgent)
var challenge *http.Response
@ -154,7 +157,10 @@ func performTokenExchange(
datac := data.Encode()
var r *http.Request
r, _ = http.NewRequest("POST", authEndpoint, bytes.NewBufferString(datac))
r, err = http.NewRequest("POST", authEndpoint, bytes.NewBufferString(datac))
if err != nil {
return "", fmt.Errorf("failed to construct request, got %v", err)
}
r.Header.Add(userAgentHeader, userAgent)
r.Header.Add("Content-Type", "application/x-www-form-urlencoded")
r.Header.Add("Content-Length", strconv.Itoa(len(datac)))