Azure - do not use 0 zone or empty string for zone when creating PVs

This commit is contained in:
Hemant Kumar
2020-04-27 16:03:36 -04:00
parent 52243decf1
commit 850da22c02
2 changed files with 10 additions and 3 deletions

View File

@@ -85,7 +85,7 @@ func (c *ManagedDiskController) CreateManagedDisk(options *ManagedDiskOptions) (
klog.V(4).Infof("azureDisk - creating new managed Name:%s StorageAccountType:%s Size:%v", options.DiskName, options.StorageAccountType, options.SizeGB) klog.V(4).Infof("azureDisk - creating new managed Name:%s StorageAccountType:%s Size:%v", options.DiskName, options.StorageAccountType, options.SizeGB)
var createZones *[]string var createZones *[]string
if len(options.AvailabilityZone) > 0 { if len(options.AvailabilityZone) > 0 && options.AvailabilityZone != "0" {
zoneList := []string{c.common.cloud.GetZoneID(options.AvailabilityZone)} zoneList := []string{c.common.cloud.GetZoneID(options.AvailabilityZone)}
createZones = &zoneList createZones = &zoneList
} }
@@ -161,13 +161,16 @@ func (c *ManagedDiskController) CreateManagedDisk(options *ManagedDiskOptions) (
model := compute.Disk{ model := compute.Disk{
Location: &c.common.location, Location: &c.common.location,
Tags: newTags, Tags: newTags,
Zones: createZones,
Sku: &compute.DiskSku{ Sku: &compute.DiskSku{
Name: diskSku, Name: diskSku,
}, },
DiskProperties: &diskProperties, DiskProperties: &diskProperties,
} }
if createZones != nil && len(*createZones) > 0 {
model.Zones = createZones
}
if options.ResourceGroup == "" { if options.ResourceGroup == "" {
options.ResourceGroup = c.common.resourceGroup options.ResourceGroup = c.common.resourceGroup
} }

View File

@@ -72,10 +72,14 @@ func (p *Provider) CreatePD(zone string) (string, error) {
PVCName: pdName, PVCName: pdName,
SizeGB: 1, SizeGB: 1,
Tags: nil, Tags: nil,
AvailabilityZone: zone,
DiskIOPSReadWrite: "", DiskIOPSReadWrite: "",
DiskMBpsReadWrite: "", DiskMBpsReadWrite: "",
} }
// do not use blank zone definition
if len(zone) > 0 && zone != "0" {
volumeOptions.AvailabilityZone = zone
}
return p.azureCloud.CreateManagedDisk(volumeOptions) return p.azureCloud.CreateManagedDisk(volumeOptions)
} }