github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-23 11:50:44 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #942 from vbalazs/update_collab_with_common_mistakes_link

Browse Source 
Update Collaborative Development with link to common mistakes
This commit is contained in:
Daniel Smith 2014-08-18 15:21:44 -07:00
commit 852b46a345
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docs/collab.md
View File

@ -20,6 +20,8 @@ If a PR has gone 2 work days without an owner emerging, please poke the PR threa
Except for rare cases, such as trivial changes (e.g. typos, comments) or emergencies (e.g. broken builds), maintainers should not merge their own changes.
Expect reviewers to request that you avoid [common go style mistakes](https://code.google.com/p/go-wiki/wiki/CodeReviewComments) in your PRs.
## Merge hours
Maintainers will do merges between the hours of 7:00 am Monday and 7:00 pm (19:00h) Friday. PRs that arrive over the weekend or on holidays will only be merged if there is a very good reason for it and if the code review requirements have been met.