From dbc6226e7f3dccf37e746cb5b9324595a2111635 Mon Sep 17 00:00:00 2001 From: Antonio Ojea Date: Sat, 13 Mar 2021 00:49:59 +0100 Subject: [PATCH] kubeadm unit test initalize global variables --- cmd/kubeadm/app/cmd/phases/init/certs_test.go | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/cmd/kubeadm/app/cmd/phases/init/certs_test.go b/cmd/kubeadm/app/cmd/phases/init/certs_test.go index 8c0f1ab2c45..d03f9d270de 100644 --- a/cmd/kubeadm/app/cmd/phases/init/certs_test.go +++ b/cmd/kubeadm/app/cmd/phases/init/certs_test.go @@ -41,6 +41,12 @@ func (t *testCertsData) CertificateDir() string { return t.cfg.Certi func (t *testCertsData) CertificateWriteDir() string { return t.cfg.CertificatesDir } func TestCertsWithCSRs(t *testing.T) { + // restore global variables + defer func() { + csrOnly = false + csrDir = "" + }() + csrDir := testutil.SetupTempDir(t) defer os.RemoveAll(csrDir) certDir := testutil.SetupTempDir(t) @@ -52,12 +58,9 @@ func TestCertsWithCSRs(t *testing.T) { } certsData.cfg.CertificatesDir = certDir - // global vars + // set global vars for the test csrOnly = true csrDir = certDir - defer func() { - csrOnly = false - }() phase := NewCertsPhase() // find the api cert phase