From 5db0778823a793b42ce70023b46fe4f2391fc211 Mon Sep 17 00:00:00 2001 From: Justin Santa Barbara Date: Mon, 16 Jan 2017 22:38:24 -0500 Subject: [PATCH] dnsprovider route53: log changeset details at v(8) Otherwise it can be hard to know exactly what is changing and whether the changes could be optimized, or to troubleshoot if someone were accidentally to have a bug in their calling code. --- .../pkg/dnsprovider/providers/aws/route53/BUILD | 1 + .../providers/aws/route53/rrchangeset.go | 13 +++++++++++++ 2 files changed, 14 insertions(+) diff --git a/federation/pkg/dnsprovider/providers/aws/route53/BUILD b/federation/pkg/dnsprovider/providers/aws/route53/BUILD index 054c94995c7..0a340777cf8 100644 --- a/federation/pkg/dnsprovider/providers/aws/route53/BUILD +++ b/federation/pkg/dnsprovider/providers/aws/route53/BUILD @@ -27,6 +27,7 @@ go_library( "//vendor:github.com/aws/aws-sdk-go/aws", "//vendor:github.com/aws/aws-sdk-go/aws/session", "//vendor:github.com/aws/aws-sdk-go/service/route53", + "//vendor:github.com/golang/glog", "//vendor:k8s.io/apimachinery/pkg/util/uuid", ], ) diff --git a/federation/pkg/dnsprovider/providers/aws/route53/rrchangeset.go b/federation/pkg/dnsprovider/providers/aws/route53/rrchangeset.go index 19b4a61f5b4..c184217efe9 100644 --- a/federation/pkg/dnsprovider/providers/aws/route53/rrchangeset.go +++ b/federation/pkg/dnsprovider/providers/aws/route53/rrchangeset.go @@ -17,8 +17,12 @@ limitations under the License. package route53 import ( + "bytes" + "fmt" + "github.com/aws/aws-sdk-go/aws" "github.com/aws/aws-sdk-go/service/route53" + "github.com/golang/glog" "k8s.io/kubernetes/federation/pkg/dnsprovider" ) @@ -93,6 +97,15 @@ func (c *ResourceRecordChangeset) Apply() error { return nil } + if glog.V(8) { + var sb bytes.Buffer + for _, change := range changes { + sb.WriteString(fmt.Sprintf("\t%s %s %s\n", aws.StringValue(change.Action), aws.StringValue(change.ResourceRecordSet.Type), aws.StringValue(change.ResourceRecordSet.Name))) + } + + glog.V(8).Infof("Route53 Changeset:\n%s", sb.String()) + } + service := c.zone.zones.interface_.service request := &route53.ChangeResourceRecordSetsInput{