github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-06 18:54:06 +00:00
Code Issues Projects Releases Wiki Activity

TestGetPodsToDelete: Use field names in test cases

Browse Source 
* pkg/controller/replicaset/replica_set_test.go (TestGetPodsToDelete): Use
explicit field names in declarations of test cases.
This commit is contained in:
Miciah Masters 2019-09-16 21:51:23 -04:00 committed by Miciah Dashiel Butler Masters
parent fef819254a
commit 865c3c5670
1 changed files with 32 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

64
pkg/controller/replicaset/replica_set_test.go
View File

@ -1468,39 +1468,39 @@ func TestGetPodsToDelete(t *testing.T) {
// a scheduled, running, ready pod // a scheduled, running, ready pod
// Note that a pending pod cannot be ready // Note that a pending pod cannot be ready
{ {
"len(pods) = 0 (i.e., diff = 0 too)", name: "len(pods) = 0 (i.e., diff = 0 too)",
[]*v1.Pod{}, pods: []*v1.Pod{},
0, diff: 0,
[]*v1.Pod{}, expectedPodsToDelete: []*v1.Pod{},
}, },
{ {
"diff = len(pods)", name: "diff = len(pods)",
[]*v1.Pod{ pods: []*v1.Pod{
scheduledRunningNotReadyPod, scheduledRunningNotReadyPod,
scheduledRunningReadyPod, scheduledRunningReadyPod,
}, },
2, diff: 2,
[]*v1.Pod{scheduledRunningNotReadyPod, scheduledRunningReadyPod}, expectedPodsToDelete: []*v1.Pod{scheduledRunningNotReadyPod, scheduledRunningReadyPod},
}, },
{ {
"diff < len(pods)", name: "diff < len(pods)",
[]*v1.Pod{ pods: []*v1.Pod{
scheduledRunningReadyPod, scheduledRunningReadyPod,
scheduledRunningNotReadyPod, scheduledRunningNotReadyPod,
}, },
1, diff: 1,
[]*v1.Pod{scheduledRunningNotReadyPod}, expectedPodsToDelete: []*v1.Pod{scheduledRunningNotReadyPod},
}, },
{ {
"various pod phases and conditions, diff = len(pods)", name: "various pod phases and conditions, diff = len(pods)",
[]*v1.Pod{ pods: []*v1.Pod{
scheduledRunningReadyPod, scheduledRunningReadyPod,
scheduledRunningNotReadyPod, scheduledRunningNotReadyPod,
scheduledPendingPod, scheduledPendingPod,
unscheduledPendingPod, unscheduledPendingPod,
}, },
4, diff: 4,
[]*v1.Pod{ expectedPodsToDelete: []*v1.Pod{
scheduledRunningReadyPod, scheduledRunningReadyPod,
scheduledRunningNotReadyPod, scheduledRunningNotReadyPod,
scheduledPendingPod, scheduledPendingPod,
@ -1508,50 +1508,50 @@ func TestGetPodsToDelete(t *testing.T) {
}, },
}, },
{ {
"scheduled vs unscheduled, diff < len(pods)", name: "scheduled vs unscheduled, diff < len(pods)",
[]*v1.Pod{ pods: []*v1.Pod{
scheduledPendingPod, scheduledPendingPod,
unscheduledPendingPod, unscheduledPendingPod,
}, },
1, diff: 1,
[]*v1.Pod{ expectedPodsToDelete: []*v1.Pod{
unscheduledPendingPod, unscheduledPendingPod,
}, },
}, },
{ {
"ready vs not-ready, diff < len(pods)", name: "ready vs not-ready, diff < len(pods)",
[]*v1.Pod{ pods: []*v1.Pod{
scheduledRunningReadyPod, scheduledRunningReadyPod,
scheduledRunningNotReadyPod, scheduledRunningNotReadyPod,
scheduledRunningNotReadyPod, scheduledRunningNotReadyPod,
}, },
2, diff: 2,
[]*v1.Pod{ expectedPodsToDelete: []*v1.Pod{
scheduledRunningNotReadyPod, scheduledRunningNotReadyPod,
scheduledRunningNotReadyPod, scheduledRunningNotReadyPod,
}, },
}, },
{ {
"pending vs running, diff < len(pods)", name: "pending vs running, diff < len(pods)",
[]*v1.Pod{ pods: []*v1.Pod{
scheduledPendingPod, scheduledPendingPod,
scheduledRunningNotReadyPod, scheduledRunningNotReadyPod,
}, },
1, diff: 1,
[]*v1.Pod{ expectedPodsToDelete: []*v1.Pod{
scheduledPendingPod, scheduledPendingPod,
}, },
}, },
{ {
"various pod phases and conditions, diff < len(pods)", name: "various pod phases and conditions, diff < len(pods)",
[]*v1.Pod{ pods: []*v1.Pod{
scheduledRunningReadyPod, scheduledRunningReadyPod,
scheduledRunningNotReadyPod, scheduledRunningNotReadyPod,
scheduledPendingPod, scheduledPendingPod,
unscheduledPendingPod, unscheduledPendingPod,
}, },
3, diff: 3,
[]*v1.Pod{ expectedPodsToDelete: []*v1.Pod{
unscheduledPendingPod, unscheduledPendingPod,
scheduledPendingPod, scheduledPendingPod,
scheduledRunningNotReadyPod, scheduledRunningNotReadyPod,