From 86f3bc25e1d48eded153d277601c52644ed1ff16 Mon Sep 17 00:00:00 2001 From: Ted Yu Date: Wed, 27 Nov 2019 08:48:06 -0800 Subject: [PATCH] Reduce unnecessary Set in updateAllocatedDevices --- pkg/kubelet/cm/devicemanager/manager.go | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/pkg/kubelet/cm/devicemanager/manager.go b/pkg/kubelet/cm/devicemanager/manager.go index 03b217a788d..2b5a6a0f032 100644 --- a/pkg/kubelet/cm/devicemanager/manager.go +++ b/pkg/kubelet/cm/devicemanager/manager.go @@ -602,12 +602,10 @@ func (m *ManagerImpl) updateAllocatedDevices(activePods []*v1.Pod) { } m.mutex.Lock() defer m.mutex.Unlock() - activePodUids := sets.NewString() + podsToBeRemoved := m.podDevices.pods() for _, pod := range activePods { - activePodUids.Insert(string(pod.UID)) + podsToBeRemoved.Delete(string(pod.UID)) } - allocatedPodUids := m.podDevices.pods() - podsToBeRemoved := allocatedPodUids.Difference(activePodUids) if len(podsToBeRemoved) <= 0 { return }