From 86f7f1dc7bf5763b76deb3087a23296710660447 Mon Sep 17 00:00:00 2001 From: Nils Carstensen Date: Thu, 18 Apr 2024 21:04:16 +0200 Subject: [PATCH] removed unused vars and improved readability --- pkg/kubelet/config/file.go | 36 +++++++++++++++++++++++++++++++----- 1 file changed, 31 insertions(+), 5 deletions(-) diff --git a/pkg/kubelet/config/file.go b/pkg/kubelet/config/file.go index 20237b21bd4..670804658e8 100644 --- a/pkg/kubelet/config/file.go +++ b/pkg/kubelet/config/file.go @@ -51,7 +51,12 @@ type sourceFile struct { } // NewSourceFile watches a config file for changes. -func NewSourceFile(path string, nodeName types.NodeName, period time.Duration, updates chan<- interface{}) { +func NewSourceFile( + path string, + nodeName types.NodeName, + period time.Duration, + updates chan<- interface{}, +) { // "github.com/sigma/go-inotify" requires a path without trailing "/" path = strings.TrimRight(path, string(os.PathSeparator)) @@ -60,7 +65,12 @@ func NewSourceFile(path string, nodeName types.NodeName, period time.Duration, u config.run() } -func newSourceFile(path string, nodeName types.NodeName, period time.Duration, updates chan<- interface{}) *sourceFile { +func newSourceFile( + path string, + nodeName types.NodeName, + period time.Duration, + updates chan<- interface{}, +) *sourceFile { send := func(objs []interface{}) { var pods []*v1.Pod for _, o := range objs { @@ -170,7 +180,12 @@ func (s *sourceFile) extractFromDir(name string) ([]*v1.Pod, error) { switch { case statInfo.Mode().IsDir(): - klog.ErrorS(nil, "Provided manifest path is a directory, not recursing into manifest path", "path", path) + klog.ErrorS( + nil, + "Provided manifest path is a directory, not recursing into manifest path", + "path", + path, + ) case statInfo.Mode().IsRegular(): pod, err := s.extractFromFile(path) if err != nil { @@ -181,7 +196,14 @@ func (s *sourceFile) extractFromDir(name string) ([]*v1.Pod, error) { pods = append(pods, pod) } default: - klog.ErrorS(nil, "Manifest path is not a directory or file", "path", path, "mode", statInfo.Mode()) + klog.ErrorS( + nil, + "Manifest path is not a directory or file", + "path", + path, + "mode", + statInfo.Mode(), + ) } } return pods, nil @@ -224,7 +246,11 @@ func (s *sourceFile) extractFromFile(filename string) (pod *v1.Pod, err error) { return pod, nil } - return pod, fmt.Errorf("%v: couldn't parse as pod(%v), please check config file", filename, podErr) + return pod, fmt.Errorf( + "%v: couldn't parse as pod(%v), please check config file", + filename, + podErr, + ) } func (s *sourceFile) replaceStore(pods ...*v1.Pod) (err error) {