From aba7e7597b38e0d0b59ebcdf2a3309cfd30600a9 Mon Sep 17 00:00:00 2001 From: Dave Chen Date: Thu, 1 Aug 2019 10:27:58 +0800 Subject: [PATCH] doc: fix couple of issues for the doc of agnhost - The code for google analytics is not well-formatted, which cause its not rendered well and properly not work as expected. - webhook v1beta1 is out, the `TODO` in the guide could be removed. Signed-off-by: Dave Chen --- test/images/agnhost/README.md | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/test/images/agnhost/README.md b/test/images/agnhost/README.md index f032d756ae6..103d0a409c5 100644 --- a/test/images/agnhost/README.md +++ b/test/images/agnhost/README.md @@ -496,20 +496,18 @@ Usage: kubectl exec test-agnhost -- /agnhost serve-hostname [--tcp] [--udp] [--http] [--close] [--port ] ``` -[![Analytics](https://kubernetes-site.appspot.com/UA-36037335-10/GitHub/contrib/for-demos/serve_hostname/README.md -?pixel)]() +[![Analytics](https://kubernetes-site.appspot.com/UA-36037335-10/GitHub/contrib/for-demos/serve_hostname/README.md?pixel)]() -[![Analytics](https://kubernetes-site.appspot.com/UA-36037335-10/GitHub/test/images/serve_hostname/README.md?pixel -)]() +[![Analytics](https://kubernetes-site.appspot.com/UA-36037335-10/GitHub/test/images/serve_hostname/README.md?pixel)]() ### webhook (Kubernetes External Admission Webhook) The subcommand tests MutatingAdmissionWebhook and ValidatingAdmissionWebhook. After deploying -it to kubernetes cluster, administrator needs to create a ValidatingWebhookConfiguration -in kubernetes cluster to register remote webhook admission controllers. +it to kubernetes cluster, administrator needs to create a MutatingWebhookConfiguration or +ValidatingWebhookConfiguration in kubernetes cluster to register remote webhook admission controllers. -TODO: add the reference when the document for admission webhook v1beta1 API is done. +More details on the configuration can be found from here [Dynamic Admission Control](https://kubernetes.io/docs/reference/access-authn-authz/extensible-admission-controllers/). Check the [MutatingAdmissionWebhook](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.14/#mutatingwebhookconfiguration-v1beta1-admissionregistration-k8s-io) and [ValidatingAdmissionWebhook](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.14/#validatingwebhookconfiguration-v1beta1-admissionregistration-k8s-io) documentations for more information about them.