github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-28 05:57:25 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #83456 from BenTheElder/jobs-may-restart

Browse Source 
check that N job pods succeeded instead of exactly N pods existing a…
This commit is contained in:
Kubernetes Prow Robot 2019-10-04 21:51:47 -07:00 committed by GitHub
commit 87adebea04
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
test/e2e/apps/job.go
View File

@ -38,7 +38,7 @@ var _ = SIGDescribe("Job", func() {
completions := int32(4) completions := int32(4)
backoffLimit := int32(6) // default value backoffLimit := int32(6) // default value
// Simplest case: all pods succeed promptly // Simplest case: N pods succeed
ginkgo.It("should run a job to completion when tasks succeed", func() { ginkgo.It("should run a job to completion when tasks succeed", func() {
ginkgo.By("Creating a job") ginkgo.By("Creating a job")
job := jobutil.NewTestJob("succeed", "all-succeed", v1.RestartPolicyNever, parallelism, completions, nil, backoffLimit) job := jobutil.NewTestJob("succeed", "all-succeed", v1.RestartPolicyNever, parallelism, completions, nil, backoffLimit)
@ -52,10 +52,13 @@ var _ = SIGDescribe("Job", func() {
ginkgo.By("Ensuring pods for job exist") ginkgo.By("Ensuring pods for job exist")
pods, err := jobutil.GetJobPods(f.ClientSet, f.Namespace.Name, job.Name) pods, err := jobutil.GetJobPods(f.ClientSet, f.Namespace.Name, job.Name)
framework.ExpectNoError(err, "failed to get pod list for job in namespace: %s", f.Namespace.Name) framework.ExpectNoError(err, "failed to get pod list for job in namespace: %s", f.Namespace.Name)
framework.ExpectEqual(len(pods.Items), int(completions), "failed to ensure sufficient pod for job: got %d, want %d", len(pods.Items), completions) successes := int32(0)
for _, pod := range pods.Items { for _, pod := range pods.Items {
framework.ExpectEqual(pod.Status.Phase, v1.PodSucceeded, "failed to ensure pod status: pod %s status %s", pod.Name, pod.Status.Phase) if pod.Status.Phase == v1.PodSucceeded {
successes++
}
} }
framework.ExpectEqual(successes, completions, "epected %d successful job pods, but got %d", completions, successes)
}) })
/* /*