From 7119fe227cbd17645f85b59ca5f11195e25faefc Mon Sep 17 00:00:00 2001 From: Rohit Agarwal Date: Wed, 15 Nov 2017 21:54:24 -0800 Subject: [PATCH] Fix TestForgivenessAdmission. This test would never fail because Annotations were empty in all cases! This was missed when Tolerations were moved from Annotations to be part of Pod.Spec in #38957. --- .../pkg/admission/defaulttolerationseconds/admission_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugin/pkg/admission/defaulttolerationseconds/admission_test.go b/plugin/pkg/admission/defaulttolerationseconds/admission_test.go index c249442dd4d..33e82498d8e 100644 --- a/plugin/pkg/admission/defaulttolerationseconds/admission_test.go +++ b/plugin/pkg/admission/defaulttolerationseconds/admission_test.go @@ -267,8 +267,8 @@ func TestForgivenessAdmission(t *testing.T) { t.Errorf("[%s]: unexpected error %v for pod %+v", test.description, err, test.requestedPod) } - if !helper.Semantic.DeepEqual(test.expectedPod.Annotations, test.requestedPod.Annotations) { - t.Errorf("[%s]: expected %#v got %#v", test.description, test.expectedPod.Annotations, test.requestedPod.Annotations) + if !helper.Semantic.DeepEqual(test.expectedPod.Spec.Tolerations, test.requestedPod.Spec.Tolerations) { + t.Errorf("[%s]: expected %#v got %#v", test.description, test.expectedPod.Spec.Tolerations, test.requestedPod.Spec.Tolerations) } } }