github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-09-03 10:17:46 +00:00
Code Issues Projects Releases Wiki Activity

event: fallback to creation when update fails

Browse Source 
Updating may fail because the item was removed from apiserver. This
patch makes sure to retry using creation instead of update.

Fixes #6289

Signed-off-by: Federico Simoncelli <fsimonce@redhat.com>
This commit is contained in:
Federico Simoncelli
2015-04-01 09:28:07 -04:00
parent f78301c5ab
commit 8849cf21d3
1 changed files with 16 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
pkg/client/record/event.go
View File

@@ -136,6 +136,17 @@ func (eventBroadcaster *eventBroadcasterImpl) StartRecordingToSink(sink EventSin
}) })
} }
func isKeyNotFoundError(err error) bool {
statusErr, _ := err.(*errors.StatusError)
// At the moment the server is returning 500 instead of a more specific
// error. When changing this remember that it should be backward compatible
// with old api servers that may be still returning 500.
if statusErr != nil && statusErr.Status().Code == 500 {
return true
}
return false
}
// recordEvent attempts to write event to a sink. It returns true if the event // recordEvent attempts to write event to a sink. It returns true if the event
// was successfully recorded or discarded, false if it should be retried. // was successfully recorded or discarded, false if it should be retried.
// If updateExistingEvent is false, it creates a new event, otherwise it updates // If updateExistingEvent is false, it creates a new event, otherwise it updates
@@ -145,7 +156,11 @@ func recordEvent(sink EventSink, event *api.Event, updateExistingEvent bool) boo
var err error var err error
if updateExistingEvent { if updateExistingEvent {
newEvent, err = sink.Update(event) newEvent, err = sink.Update(event)
} else { }
// Update can fail because the event may have been removed and it no longer exists.
if !updateExistingEvent || (updateExistingEvent && isKeyNotFoundError(err)) {
// Making sure that ResourceVersion is empty on creation
event.ResourceVersion = ""
newEvent, err = sink.Create(event) newEvent, err = sink.Create(event)
} }
if err == nil { if err == nil {