github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-28 22:17:14 +00:00
Code Issues Projects Releases Wiki Activity

Avoid creating more delete collection workers than items to delete

Browse Source
This commit is contained in:
Brian Pursley 2020-05-29 08:57:03 -04:00
parent 56ad0cefbd
commit 88885b6776
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
staging/src/k8s.io/apiserver/pkg/registry/generic/registry/store.go
View File

@ -1006,12 +1006,19 @@ func (e *Store) DeleteCollection(ctx context.Context, deleteValidation rest.Vali
if err != nil { if err != nil {
return nil, err return nil, err
} }
if len(items) == 0 {
// Nothing to delete, return now
return listObj, nil
}
// Spawn a number of goroutines, so that we can issue requests to storage // Spawn a number of goroutines, so that we can issue requests to storage
// in parallel to speed up deletion. // in parallel to speed up deletion.
// TODO: Make this proportional to the number of items to delete, up to // It is proportional to the number of items to delete, up to
// DeleteCollectionWorkers (it doesn't make much sense to spawn 16 // DeleteCollectionWorkers (it doesn't make much sense to spawn 16
// workers to delete 10 items). // workers to delete 10 items).
workersNumber := e.DeleteCollectionWorkers workersNumber := e.DeleteCollectionWorkers
if workersNumber > len(items) {
workersNumber = len(items)
}
if workersNumber < 1 { if workersNumber < 1 {
workersNumber = 1 workersNumber = 1
} }