From 889dcb5b54d64058aca0a4747190bbec3ce1c8b8 Mon Sep 17 00:00:00 2001 From: Francesco Romani Date: Mon, 28 Jun 2021 16:29:25 +0200 Subject: [PATCH] e2e: node: fix npd test failures bumping image The PR https://github.com/kubernetes/kubernetes/pull/100041 updated node-problem-detector to v0.8.7, but unfortunately we didn't update also the image using in the e2e_node tests. As result, the tests were failing like E2eNode Suite: [sig-node] NodeProblemDetector [NodeFeature:NodeProblemDetector] [Serial] SystemLogMonitor should generate node condition and events for corresponding errors _output/local/go/src/k8s.io/kubernetes/test/e2e_node/node_problem_detector_linux.go:301 Timed out after 60.000s. Expected success, but got an error: <*errors.errorString | 0xc0011f2600>: { s: "expected total number of events was 4, actual events counted was 7\nEvents This in turn was one of the contributing factors in making the pull-kubernetes-node-kubelet-serial lane constantly failing. This patch updates the image used in the tests, fixing the failure. Signed-off-by: Francesco Romani --- test/e2e_node/image_list.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/e2e_node/image_list.go b/test/e2e_node/image_list.go index c604f68c20a..dbae408c251 100644 --- a/test/e2e_node/image_list.go +++ b/test/e2e_node/image_list.go @@ -87,7 +87,7 @@ func updateImageAllowList() { } func getNodeProblemDetectorImage() string { - const defaultImage string = "k8s.gcr.io/node-problem-detector:v0.6.2" + const defaultImage string = "k8s.gcr.io/node-problem-detector/node-problem-detector:v0.8.7" image := os.Getenv("NODE_PROBLEM_DETECTOR_IMAGE") if image == "" { image = defaultImage