From 96e2610a55ec4fb133024edd9fa9b563b394aa3c Mon Sep 17 00:00:00 2001 From: Yanqiang Miao Date: Thu, 16 Nov 2017 15:41:49 +0800 Subject: [PATCH] Use `sets` instead of `for` statement in "IsValidAuthorizationMode" --- pkg/kubeapiserver/authorizer/modes/BUILD | 1 + pkg/kubeapiserver/authorizer/modes/modes.go | 9 +++------ 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/pkg/kubeapiserver/authorizer/modes/BUILD b/pkg/kubeapiserver/authorizer/modes/BUILD index 9be3d02c9a8..a72eb46d7e4 100644 --- a/pkg/kubeapiserver/authorizer/modes/BUILD +++ b/pkg/kubeapiserver/authorizer/modes/BUILD @@ -17,6 +17,7 @@ go_library( name = "go_default_library", srcs = ["modes.go"], importpath = "k8s.io/kubernetes/pkg/kubeapiserver/authorizer/modes", + deps = ["//vendor/k8s.io/apimachinery/pkg/util/sets:go_default_library"], ) filegroup( diff --git a/pkg/kubeapiserver/authorizer/modes/modes.go b/pkg/kubeapiserver/authorizer/modes/modes.go index 56a708a6b1d..54d0a627701 100644 --- a/pkg/kubeapiserver/authorizer/modes/modes.go +++ b/pkg/kubeapiserver/authorizer/modes/modes.go @@ -16,6 +16,8 @@ limitations under the License. package modes +import "k8s.io/apimachinery/pkg/util/sets" + const ( ModeAlwaysAllow string = "AlwaysAllow" ModeAlwaysDeny string = "AlwaysDeny" @@ -29,10 +31,5 @@ var AuthorizationModeChoices = []string{ModeAlwaysAllow, ModeAlwaysDeny, ModeABA // IsValidAuthorizationMode returns true if the given authorization mode is a valid one for the apiserver func IsValidAuthorizationMode(authzMode string) bool { - for _, validMode := range AuthorizationModeChoices { - if authzMode == validMode { - return true - } - } - return false + return sets.NewString(AuthorizationModeChoices...).Has(authzMode) }