Merge pull request #119197 from saschagrunert/stop-container-runtime-err

Check dbus error on container runtime start/stop
This commit is contained in:
Kubernetes Prow Robot 2023-08-16 15:27:52 -07:00 committed by GitHub
commit 88d14edc26
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -393,7 +393,7 @@ const (
)
func performContainerRuntimeUnitOp(op containerRuntimeUnitOp) error {
ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
ctx, cancel := context.WithTimeout(context.Background(), 2*time.Minute)
defer cancel()
conn, err := dbus.NewWithContext(ctx)
@ -409,12 +409,13 @@ func performContainerRuntimeUnitOp(op containerRuntimeUnitOp) error {
switch op {
case startContainerRuntimeUnitOp:
conn.StartUnitContext(ctx, containerRuntimeUnitName, "replace", reschan)
_, err = conn.StartUnitContext(ctx, containerRuntimeUnitName, "replace", reschan)
case stopContainerRuntimeUnitOp:
conn.StopUnitContext(ctx, containerRuntimeUnitName, "replace", reschan)
_, err = conn.StopUnitContext(ctx, containerRuntimeUnitName, "replace", reschan)
default:
framework.Failf("Unexpected container runtime op: %v", op)
}
framework.ExpectNoError(err, "dbus connection error")
job := <-reschan
framework.ExpectEqual(job, "done", "Expected job to complete with done")