github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-23 19:56:01 +00:00
Code Issues Projects Releases Wiki Activity

in GuaranteedUpdate, retry on precondition check failure if we are working with cached data

Browse Source
This commit is contained in:
Haowei Cai 2019-09-03 17:26:39 -07:00
parent 2670651a3c
commit 88f0be6e59
1 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
staging/src/k8s.io/apiserver/pkg/storage/etcd3/store.go
View File

@ -274,7 +274,20 @@ func (s *store) GuaranteedUpdate(
transformContext := authenticatedDataString(key) transformContext := authenticatedDataString(key)
for { for {
if err := preconditions.Check(key, origState.obj); err != nil { if err := preconditions.Check(key, origState.obj); err != nil {
return err // If our data is already up to date, return the error
if !mustCheckData {
return err
}
// It's possible we were working with stale data
// Actually fetch
origState, err = getCurrentState()
if err != nil {
return err
}
mustCheckData = false
// Retry
continue
} }
ret, ttl, err := s.updateState(origState, tryUpdate) ret, ttl, err := s.updateState(origState, tryUpdate)