From 094b78d7dead5ca474a8489c3494801a5398ea5f Mon Sep 17 00:00:00 2001 From: Claire Li Date: Fri, 11 Jul 2014 22:13:29 -0700 Subject: [PATCH] pkg/proxy: filtering before comparing --- pkg/proxy/roundrobbin.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pkg/proxy/roundrobbin.go b/pkg/proxy/roundrobbin.go index 9d9f2413540..bb93922798e 100644 --- a/pkg/proxy/roundrobbin.go +++ b/pkg/proxy/roundrobbin.go @@ -85,9 +85,10 @@ func (impl LoadBalancerRR) OnUpdate(endpoints []api.Endpoints) { // First update / add all new endpoints for services. for _, value := range endpoints { existingEndpoints, exists := impl.endpointsMap[value.Name] - if !exists || !reflect.DeepEqual(value.Endpoints, existingEndpoints) { + validEndpoints := impl.FilterValidEndpoints(value.Endpoints) + if !exists || !reflect.DeepEqual(existingEndpoints, validEndpoints) { glog.Infof("LoadBalancerRR: Setting endpoints for %s to %+v", value.Name, value.Endpoints) - impl.endpointsMap[value.Name] = impl.FilterValidEndpoints(value.Endpoints) + impl.endpointsMap[value.Name] = validEndpoints // Start RR from the beginning if added or updated. impl.rrIndex[value.Name] = 0 }