From 8ae6a2048573041766bc103fba106268e78e8460 Mon Sep 17 00:00:00 2001 From: hasheddan Date: Sat, 6 Feb 2021 11:03:00 -0600 Subject: [PATCH] kubeadm: drop explicit constant override in version test The k8s release bucket constant is not longer overriden in network tests because the fetcher is mocked rather than using httptest.NewServer. See previous implementation in https://github.com/kubernetes/kubernetes/pull/49119/files#diff-82f2b09991047d4a1884d53dedadd64a473d5c4dc75293514e71773ceedf08e2R128 Signed-off-by: hasheddan --- cmd/kubeadm/app/util/version_test.go | 3 --- 1 file changed, 3 deletions(-) diff --git a/cmd/kubeadm/app/util/version_test.go b/cmd/kubeadm/app/util/version_test.go index 24e2f5a0396..c392a6a2e5d 100644 --- a/cmd/kubeadm/app/util/version_test.go +++ b/cmd/kubeadm/app/util/version_test.go @@ -203,9 +203,6 @@ func TestSplitVersion(t *testing.T) { // unknown area, not valid input. {"unknown/latest-1", "", "", false}, } - // kubeReleaseBucketURL can be overridden during network tests, thus ensure - // it will contain value corresponding to expected outcome for this unit test - kubeReleaseBucketURL = "https://dl.k8s.io" for _, tc := range cases { t.Run(fmt.Sprintf("input:%s/label:%s", tc.input, tc.label), func(t *testing.T) {