From 8ae868b4e07662f6d692e6cd62390e6a8c398249 Mon Sep 17 00:00:00 2001 From: Somtochi Onyekwere Date: Wed, 22 Jan 2020 00:36:12 +0100 Subject: [PATCH] Adds more test cases in TestRunBindPlugins for the scheduler --- .../framework/v1alpha1/framework_test.go | 40 +++++++++++++++++++ 1 file changed, 40 insertions(+) diff --git a/pkg/scheduler/framework/v1alpha1/framework_test.go b/pkg/scheduler/framework/v1alpha1/framework_test.go index 424fae0c0d2..9d6d8e24233 100644 --- a/pkg/scheduler/framework/v1alpha1/framework_test.go +++ b/pkg/scheduler/framework/v1alpha1/framework_test.go @@ -1064,6 +1064,46 @@ func TestRunBindPlugins(t *testing.T) { injects: []Code{Skip, Success, Error}, wantStatus: Success, }, + { + name: "no bind plugin, returns default binder", + injects: []Code{}, + wantStatus: Success, + }, + { + name: "invalid status", + injects: []Code{Unschedulable}, + wantStatus: Error, + }, + { + name: "simple error", + injects: []Code{Error}, + wantStatus: Error, + }, + { + name: "success on second, returns success", + injects: []Code{Skip, Success}, + wantStatus: Success, + }, + { + name: "invalid status, returns error", + injects: []Code{Skip, UnschedulableAndUnresolvable}, + wantStatus: Error, + }, + { + name: "error after success status, returns success", + injects: []Code{Success, Error}, + wantStatus: Success, + }, + { + name: "success before invalid status, returns success", + injects: []Code{Success, Error}, + wantStatus: Success, + }, + { + name: "success after error status, returns error", + injects: []Code{Error, Success}, + wantStatus: Error, + }, } for _, tt := range tests { t.Run(tt.name, func(t *testing.T) {