From 83818ee0c8995d766a0d6c99aa75ac3a57484e9f Mon Sep 17 00:00:00 2001
From: Mayank Kumar <mayank.kumar@salesforce.com>
Date: Thu, 24 May 2018 23:26:02 -0700
Subject: [PATCH] simplify else

---
 .../algorithm/priorities/node_affinity.go     |  7 +++---
 pkg/scheduler/schedulercache/node_info.go     | 22 +++++++++----------
 2 files changed, 14 insertions(+), 15 deletions(-)

diff --git a/pkg/scheduler/algorithm/priorities/node_affinity.go b/pkg/scheduler/algorithm/priorities/node_affinity.go
index ca0a351650e..347f797d776 100644
--- a/pkg/scheduler/algorithm/priorities/node_affinity.go
+++ b/pkg/scheduler/algorithm/priorities/node_affinity.go
@@ -37,12 +37,11 @@ func CalculateNodeAffinityPriorityMap(pod *v1.Pod, meta interface{}, nodeInfo *s
 		return schedulerapi.HostPriority{}, fmt.Errorf("node not found")
 	}
 
-	var affinity *v1.Affinity
+	// default is the podspec.
+	affinity := pod.Spec.Affinity
 	if priorityMeta, ok := meta.(*priorityMetadata); ok {
+		// We were able to parse metadata, use affinity from there.
 		affinity = priorityMeta.affinity
-	} else {
-		// We couldn't parse metadata - fallback to the podspec.
-		affinity = pod.Spec.Affinity
 	}
 
 	var count int32
diff --git a/pkg/scheduler/schedulercache/node_info.go b/pkg/scheduler/schedulercache/node_info.go
index 2773437327f..b5829cfca3d 100644
--- a/pkg/scheduler/schedulercache/node_info.go
+++ b/pkg/scheduler/schedulercache/node_info.go
@@ -603,18 +603,18 @@ func (n *NodeInfo) FilterOutPods(pods []*v1.Pod) []*v1.Pod {
 	}
 	filtered := make([]*v1.Pod, 0, len(pods))
 	for _, p := range pods {
-		if p.Spec.NodeName == node.Name {
-			// If pod is on the given node, add it to 'filtered' only if it is present in nodeInfo.
-			podKey, _ := getPodKey(p)
-			for _, np := range n.Pods() {
-				npodkey, _ := getPodKey(np)
-				if npodkey == podKey {
-					filtered = append(filtered, p)
-					break
-				}
-			}
-		} else {
+		if p.Spec.NodeName != node.Name {
 			filtered = append(filtered, p)
+			continue
+		}
+		// If pod is on the given node, add it to 'filtered' only if it is present in nodeInfo.
+		podKey, _ := getPodKey(p)
+		for _, np := range n.Pods() {
+			npodkey, _ := getPodKey(np)
+			if npodkey == podKey {
+				filtered = append(filtered, p)
+				break
+			}
 		}
 	}
 	return filtered