mirror of
https://github.com/k3s-io/kubernetes.git
synced 2025-07-23 11:50:44 +00:00
Merge pull request #65985 from ixdy/readd-pkg-generated-bindata.go
Automatic merge from submit-queue (batch tested with PRs 65993, 65986, 65351, 65996, 65985). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Re-add pkg/generated/bindata.go **What this PR does / why we need it**: I removed `pkg/generated/bindata.go` in #62432 as it had drifted out-of-date and was automatically generated by `make` and `bazel`. This broke some downstream users who import `k8s.io/kubernetes`. It's unclear whether the project intends for `k8s.io/kubernetes` to be vendorable, as there are other generated files which are not saved in the repo, including `pkg/generated/openapi/zz_generated.openapi.go` and `test/e2e/generated/bindata.go`, but `pkg/generated/bindata.go` seems to be a core dependency for current uses. The new verify check added in #65882 will ensure that this file stays up-to-date. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: This partially addresses #65968. We also need to cherry-pick this to release-1.11. **Release note**: ```release-note Re-adds `pkg/generated/bindata.go` to the repository to allow some parts of k8s.io/kubernetes to be go-vendorable. ```
This commit is contained in:
commit
8b71cb743d
1
.gitignore
vendored
1
.gitignore
vendored
@ -116,7 +116,6 @@ zz_generated.openapi.go
|
||||
/.make/
|
||||
|
||||
# Just in time generated data in the source, should never be committed
|
||||
/pkg/generated/bindata.go
|
||||
/test/e2e/generated/bindata.go
|
||||
|
||||
# This file used by some vendor repos (e.g. github.com/go-openapi/...) to store secret variables and should not be ignored
|
||||
|
19624
pkg/generated/bindata.go
Normal file
19624
pkg/generated/bindata.go
Normal file
File diff suppressed because one or more lines are too long
Loading…
Reference in New Issue
Block a user