github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-28 05:57:25 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #34243 from liggitt/simplify-raw

Browse Source 
Automatic merge from submit-queue

Simplify kubectl get --raw

Write to configured output stream
Don't assume output is a string
This commit is contained in:
Kubernetes Submit Queue 2016-10-07 06:29:10 -07:00 committed by GitHub
commit 8b834dd5c0
1 changed files with 4 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
pkg/kubectl/cmd/get.go
View File

@ -138,19 +138,11 @@ func RunGet(f *cmdutil.Factory, out io.Writer, errOut io.Writer, cmd *cobra.Comm
} }
defer stream.Close() defer stream.Close()
for { _, err = io.Copy(out, stream)
buffer := make([]byte, 1024, 1024) if err != nil && err != io.EOF {
bytesRead, err := stream.Read(buffer) return err
if bytesRead > 0 {
fmt.Printf("%s", string(buffer[:bytesRead]))
}
if err == io.EOF {
return nil
}
if err != nil {
return err
}
} }
return nil
} }
selector := cmdutil.GetFlagString(cmd, "selector") selector := cmdutil.GetFlagString(cmd, "selector")