From fdbb32884eb03f61472bd457d04481b56641c9e9 Mon Sep 17 00:00:00 2001 From: Davanum Srinivas Date: Tue, 8 Sep 2020 15:22:08 -0400 Subject: [PATCH] Sort list of formats for --logging-format description to make it deterministic Signed-off-by: Davanum Srinivas --- staging/src/k8s.io/component-base/logs/registry.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/staging/src/k8s.io/component-base/logs/registry.go b/staging/src/k8s.io/component-base/logs/registry.go index 515bba28011..c71899db66d 100644 --- a/staging/src/k8s.io/component-base/logs/registry.go +++ b/staging/src/k8s.io/component-base/logs/registry.go @@ -18,6 +18,7 @@ package logs import ( "fmt" + "sort" "github.com/go-logr/logr" json "k8s.io/component-base/logs/json" @@ -84,12 +85,13 @@ func (lfr *LogFormatRegistry) Delete(name string) error { return nil } -// List names of registered log formats +// List names of registered log formats (sorted) func (lfr *LogFormatRegistry) List() []string { formats := make([]string, 0, len(lfr.registry)) for f := range lfr.registry { formats = append(formats, f) } + sort.Strings(formats) return formats }