From 8bf30530e870aea72f459db886c1e7cf20b8c73a Mon Sep 17 00:00:00 2001 From: Abdullah Gharaibeh Date: Fri, 5 Jun 2020 16:03:45 -0400 Subject: [PATCH] Remove unnecessary log message causing significant overhead on preemption evaluation --- pkg/scheduler/core/generic_scheduler.go | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/pkg/scheduler/core/generic_scheduler.go b/pkg/scheduler/core/generic_scheduler.go index e31993ed8f6..eaf31a5bbf1 100644 --- a/pkg/scheduler/core/generic_scheduler.go +++ b/pkg/scheduler/core/generic_scheduler.go @@ -273,6 +273,13 @@ func (g *genericScheduler) Preempt(ctx context.Context, prof *profile.Profile, s // In this case, we should clean-up any existing nominated node name of the pod. return "", nil, []*v1.Pod{pod}, nil } + if klog.V(5).Enabled() { + var sample []string + for i := 0; i < 10 && i < len(potentialNodes); i++ { + sample = append(sample, potentialNodes[i].Node().Name) + } + klog.Infof("%v potential nodes for preemption, first %v are: %v", len(potentialNodes), len(sample), sample) + } var pdbs []*policy.PodDisruptionBudget if g.pdbLister != nil { pdbs, err = g.pdbLister.List(labels.Everything()) @@ -1042,7 +1049,6 @@ func nodesWherePreemptionMightHelp(nodes []*framework.NodeInfo, fitErr *FitError if fitErr.FilteredNodesStatuses[name].Code() == framework.UnschedulableAndUnresolvable { continue } - klog.V(3).Infof("Node %v is a potential node for preemption.", name) potentialNodes = append(potentialNodes, node) } return potentialNodes