github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-15 06:43:54 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #45157 from k82cn/rm_rc_comments

Browse Source 
Automatic merge from submit-queue

Removed TODO that renaming ReplicationManager.

**What this PR does / why we need it**:
Updated comments to avoid potential PRs on renaming.

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # N/A

**Release note**:

```release-note-none
```
This commit is contained in:
Kubernetes Submit Queue 2017-04-30 08:36:07 -07:00 committed by GitHub
commit 8c188b2bce
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/controller/replication/replication_controller.go
View File

@ -61,8 +61,8 @@ var controllerKind = v1.SchemeGroupVersion.WithKind("ReplicationController")
// ReplicationManager is responsible for synchronizing ReplicationController objects stored // ReplicationManager is responsible for synchronizing ReplicationController objects stored
// in the system with actual running pods. // in the system with actual running pods.
// TODO: this really should be called ReplicationController. The only reason why it's a Manager // NOTE: using this name to distinguish this type from API object "ReplicationController"; will
// is to distinguish this type from API object "ReplicationController". We should fix this. // not fix it right now. Refer to #41459 for more detail.
type ReplicationManager struct { type ReplicationManager struct {
kubeClient clientset.Interface kubeClient clientset.Interface
podControl controller.PodControlInterface podControl controller.PodControlInterface