Add group to apiserver tracing

This commit is contained in:
HirazawaUi 2023-09-03 21:11:08 +08:00
parent 751058c0a4
commit 8c34208a62
3 changed files with 31 additions and 0 deletions

View File

@ -77,6 +77,24 @@ func (lazy *lazyAccept) String() string {
return "unknown"
}
// lazyAPIGroup implements String() string and it will
// lazily get Group from request info.
type lazyAPIGroup struct {
req *http.Request
}
func (lazy *lazyAPIGroup) String() string {
if lazy.req != nil {
ctx := lazy.req.Context()
requestInfo, ok := apirequest.RequestInfoFrom(ctx)
if ok {
return requestInfo.APIGroup
}
}
return "unknown"
}
// lazyAuditID implements Stringer interface to lazily retrieve
// the audit ID associated with the request.
type lazyAuditID struct {

View File

@ -85,6 +85,18 @@ func TestLazyVerb(t *testing.T) {
assert.Equal(t, "WATCH", fmt.Sprintf("%v", verbWithReq))
}
func TestLazyApiGroup(t *testing.T) {
assert.Equal(t, "unknown", fmt.Sprintf("%v", &lazyAPIGroup{}))
scopeWithEmptyReq := &lazyAPIGroup{&http.Request{}}
assert.Equal(t, "unknown", fmt.Sprintf("%v", scopeWithEmptyReq))
req := &http.Request{}
ctx := request.WithRequestInfo(context.TODO(), &request.RequestInfo{APIGroup: "apps"})
scopeWithReq := &lazyAPIGroup{req: req.WithContext(ctx)}
assert.Equal(t, "apps", fmt.Sprintf("%v", scopeWithReq))
}
func TestLazyResource(t *testing.T) {
assert.Equal(t, "unknown", fmt.Sprintf("%v", &lazyResource{}))

View File

@ -27,6 +27,7 @@ func traceFields(req *http.Request) []attribute.KeyValue {
attribute.Stringer("accept", &lazyAccept{req: req}),
attribute.Stringer("audit-id", &lazyAuditID{req: req}),
attribute.Stringer("client", &lazyClientIP{req: req}),
attribute.Stringer("api-group", &lazyAPIGroup{req: req}),
attribute.String("protocol", req.Proto),
attribute.Stringer("resource", &lazyResource{req: req}),
attribute.Stringer("scope", &lazyScope{req: req}),