From 04b1378804886c2ee979f75bf4160c2137ddc087 Mon Sep 17 00:00:00 2001 From: zylxjtu Date: Fri, 25 Oct 2024 10:16:47 -0700 Subject: [PATCH] Fix the incorrect metrics setting/naming in nodeshutdown manager --- pkg/kubelet/metrics/metrics.go | 2 +- pkg/kubelet/nodeshutdown/nodeshutdown_manager_linux.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/kubelet/metrics/metrics.go b/pkg/kubelet/metrics/metrics.go index 30a194a3a66..79e7ce9ea52 100644 --- a/pkg/kubelet/metrics/metrics.go +++ b/pkg/kubelet/metrics/metrics.go @@ -739,7 +739,7 @@ var ( &metrics.GaugeOpts{ Subsystem: KubeletSubsystem, Name: "graceful_shutdown_end_time_seconds", - Help: "Last graceful shutdown start time since unix epoch in seconds", + Help: "Last graceful shutdown end time since unix epoch in seconds", StabilityLevel: metrics.ALPHA, }, ) diff --git a/pkg/kubelet/nodeshutdown/nodeshutdown_manager_linux.go b/pkg/kubelet/nodeshutdown/nodeshutdown_manager_linux.go index 79299651e9c..7cdd57a7c6f 100644 --- a/pkg/kubelet/nodeshutdown/nodeshutdown_manager_linux.go +++ b/pkg/kubelet/nodeshutdown/nodeshutdown_manager_linux.go @@ -321,7 +321,7 @@ func (m *managerImpl) processShutdownEvent() error { if err != nil { m.logger.Error(err, "Failed to store graceful shutdown state") } - metrics.GracefulShutdownStartTime.Set(timestamp(endTime)) + metrics.GracefulShutdownEndTime.Set(timestamp(endTime)) }() }