diff --git a/pkg/api/conversion.go b/pkg/api/conversion.go index f5ceb96bbcd..453edbf13f4 100644 --- a/pkg/api/conversion.go +++ b/pkg/api/conversion.go @@ -35,15 +35,6 @@ func init() { obj.LabelSelector = labels.Everything() obj.FieldSelector = fields.Everything() }, - // TODO: see about moving this into v1/defaults.go - func(obj *PodExecOptions) { - obj.Stderr = true - obj.Stdout = true - }, - func(obj *PodAttachOptions) { - obj.Stderr = true - obj.Stdout = true - }, ) Scheme.AddConversionFuncs( func(in *unversioned.Time, out *unversioned.Time, s conversion.Scope) error { diff --git a/pkg/api/serialization_test.go b/pkg/api/serialization_test.go index 5b32f8af6a5..555628f1a68 100644 --- a/pkg/api/serialization_test.go +++ b/pkg/api/serialization_test.go @@ -70,7 +70,7 @@ func roundTrip(t *testing.T, codec runtime.Codec, item runtime.Object) { return } if !api.Semantic.DeepEqual(item, obj2) { - t.Errorf("1: %v: diff: %v\nCodec: %v\nSource:\n\n%#v\n\nEncoded:\n\n%s\n\nFinal:\n\n%#v", name, util.ObjectGoPrintDiff(item, obj2), codec, printer.Sprintf("%#v", item), string(data), printer.Sprintf("%#v", obj2)) + t.Errorf("\n1: %v: diff: %v\nCodec: %v\nSource:\n\n%#v\n\nEncoded:\n\n%s\n\nFinal:\n\n%#v", name, util.ObjectGoPrintDiff(item, obj2), codec, printer.Sprintf("%#v", item), string(data), printer.Sprintf("%#v", obj2)) return } @@ -128,7 +128,8 @@ func TestList(t *testing.T) { } var nonRoundTrippableTypes = sets.NewString() -var nonInternalRoundTrippableTypes = sets.NewString("List", "ListOptions", "PodExecOptions", "PodAttachOptions") + +var nonInternalRoundTrippableTypes = sets.NewString("List", "ListOptions") var nonRoundTrippableTypesByVersion = map[string][]string{} func TestRoundTripTypes(t *testing.T) { diff --git a/pkg/api/testing/fuzzer.go b/pkg/api/testing/fuzzer.go index 2fceb88e21f..50d13a20d78 100644 --- a/pkg/api/testing/fuzzer.go +++ b/pkg/api/testing/fuzzer.go @@ -91,6 +91,14 @@ func FuzzerFor(t *testing.T, version string, src rand.Source) *fuzz.Fuzzer { j.LabelSelector, _ = labels.Parse("a=b") j.FieldSelector, _ = fields.ParseSelector("a=b") }, + func(j *api.PodExecOptions, c fuzz.Continue) { + j.Stdout = true + j.Stderr = true + }, + func(j *api.PodAttachOptions, c fuzz.Continue) { + j.Stdout = true + j.Stderr = true + }, func(s *api.PodSpec, c fuzz.Continue) { c.FuzzNoCustom(s) // has a default value diff --git a/pkg/api/v1/defaults.go b/pkg/api/v1/defaults.go index 2cc086be4f9..445c449378b 100644 --- a/pkg/api/v1/defaults.go +++ b/pkg/api/v1/defaults.go @@ -25,6 +25,14 @@ import ( func addDefaultingFuncs() { api.Scheme.AddDefaultingFuncs( + func(obj *PodExecOptions) { + obj.Stdout = true + obj.Stderr = true + }, + func(obj *PodAttachOptions) { + obj.Stdout = true + obj.Stderr = true + }, func(obj *ReplicationController) { var labels map[string]string if obj.Spec.Template != nil {