github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-09-11 14:11:14 +00:00
Code Issues Projects Releases Wiki Activity

Simplify DNS validation checks

Browse Source 
Move DNS length checks to util/validation.go.  Make the max subdomain be 253,
which is what the RFC actually says.
This commit is contained in:
Tim Hockin
2014-07-08 13:44:30 -07:00
parent 40c71e8292
commit 8d6e832b8e
4 changed files with 35 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
pkg/util/validation.go
View File

@@ -20,25 +20,32 @@ import (
"regexp"
)
var dnsLabelFmt string = "[a-z0-9]([-a-z0-9]*[a-z0-9])?"
const dnsLabelFmt string = "[a-z0-9]([-a-z0-9]*[a-z0-9])?"
var dnsLabelRegexp *regexp.Regexp = regexp.MustCompile("^" + dnsLabelFmt + "$")
const dnsLabelMaxLength int = 63
// IsDNSLabel tests for a string that conforms to the definition of a label in
// DNS (RFC 1035/1123). This checks the format, but not the length.
// DNS (RFC 1035/1123).
func IsDNSLabel(value string) bool {
return dnsLabelRegexp.MatchString(value)
return len(value) <= dnsLabelMaxLength && dnsLabelRegexp.MatchString(value)
}
var dnsSubdomainFmt string = dnsLabelFmt + "(\\." + dnsLabelFmt + ")*"
const dnsSubdomainFmt string = dnsLabelFmt + "(\\." + dnsLabelFmt + ")*"
var dnsSubdomainRegexp *regexp.Regexp = regexp.MustCompile("^" + dnsSubdomainFmt + "$")
const dnsSubdomainMaxLength int = 253
// IsDNSSubdomain tests for a string that conforms to the definition of a
// subdomain in DNS (RFC 1035/1123). This checks the format, but not the length.
// subdomain in DNS (RFC 1035/1123).
func IsDNSSubdomain(value string) bool {
return dnsSubdomainRegexp.MatchString(value)
return len(value) <= dnsSubdomainMaxLength && dnsSubdomainRegexp.MatchString(value)
}
var cIdentifierFmt string = "[A-Za-z_][A-Za-z0-9_]*"
const cIdentifierFmt string = "[A-Za-z_][A-Za-z0-9_]*"
var cIdentifierRegexp *regexp.Regexp = regexp.MustCompile("^" + cIdentifierFmt + "$")
// IsCIdentifier tests for a string that conforms the definition of an identifier