github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-27 05:27:21 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #103868 from qingsenLi/210723-forget

Browse Source 
Merge conditional assignment into variable declaration
This commit is contained in:
Kubernetes Prow Robot 2021-10-28 16:32:50 -07:00 committed by GitHub
commit 8e37a3b324
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
pkg/controller/job/job_controller.go
View File

@ -800,14 +800,11 @@ func (jm *Controller) syncJob(key string) (forget bool, rErr error) {
} }
} }
forget = false
// Check if the number of jobs succeeded increased since the last check. If yes "forget" should be true // Check if the number of jobs succeeded increased since the last check. If yes "forget" should be true
// This logic is linked to the issue: https://github.com/kubernetes/kubernetes/issues/56853 that aims to // This logic is linked to the issue: https://github.com/kubernetes/kubernetes/issues/56853 that aims to
// improve the Job backoff policy when parallelism > 1 and few Jobs failed but others succeed. // improve the Job backoff policy when parallelism > 1 and few Jobs failed but others succeed.
// In this case, we should clear the backoff delay. // In this case, we should clear the backoff delay.
if job.Status.Succeeded < succeeded { forget = job.Status.Succeeded < succeeded
forget = true
}
if uncounted != nil { if uncounted != nil {
needsStatusUpdate := suspendCondChanged || active != job.Status.Active || !equalReady(ready, job.Status.Ready) needsStatusUpdate := suspendCondChanged || active != job.Status.Active || !equalReady(ready, job.Status.Ready)