Merge pull request #115925 from claudiubelu/skip-flaky-tests

unit tests: Skip flaky tests on Windows
This commit is contained in:
Kubernetes Prow Robot 2023-03-06 21:56:29 -08:00 committed by GitHub
commit 8e659d43ec
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 0 deletions

View File

@ -19,6 +19,7 @@ package nodelifecycle
import ( import (
"context" "context"
"fmt" "fmt"
goruntime "runtime"
"strings" "strings"
"testing" "testing"
"time" "time"
@ -2759,6 +2760,10 @@ func TestMonitorNodeHealthMarkPodsNotReadyRetry(t *testing.T) {
// NodeController is just responsible for enqueuing the node to tainting queue from which taint manager picks up // NodeController is just responsible for enqueuing the node to tainting queue from which taint manager picks up
// and evicts the pods on the node. // and evicts the pods on the node.
func TestApplyNoExecuteTaints(t *testing.T) { func TestApplyNoExecuteTaints(t *testing.T) {
// TODO: Remove skip once https://github.com/kubernetes/kubernetes/pull/114607 merges.
if goruntime.GOOS == "windows" {
t.Skip("Skipping test on Windows.")
}
fakeNow := metav1.Date(2017, 1, 1, 12, 0, 0, 0, time.UTC) fakeNow := metav1.Date(2017, 1, 1, 12, 0, 0, 0, time.UTC)
evictionTimeout := 10 * time.Minute evictionTimeout := 10 * time.Minute

View File

@ -21,6 +21,7 @@ import (
"os" "os"
"path/filepath" "path/filepath"
"reflect" "reflect"
goruntime "runtime"
"sync" "sync"
"sync/atomic" "sync/atomic"
"testing" "testing"
@ -121,6 +122,10 @@ func TestNewManagerImplStartProbeMode(t *testing.T) {
// making sure that after registration, devices are correctly updated and if a re-registration // making sure that after registration, devices are correctly updated and if a re-registration
// happens, we will NOT delete devices; and no orphaned devices left. // happens, we will NOT delete devices; and no orphaned devices left.
func TestDevicePluginReRegistration(t *testing.T) { func TestDevicePluginReRegistration(t *testing.T) {
// TODO: Remove skip once https://github.com/kubernetes/kubernetes/pull/115269 merges.
if goruntime.GOOS == "windows" {
t.Skip("Skipping test on Windows.")
}
socketDir, socketName, pluginSocketName, err := tmpSocketDir() socketDir, socketName, pluginSocketName, err := tmpSocketDir()
require.NoError(t, err) require.NoError(t, err)
defer os.RemoveAll(socketDir) defer os.RemoveAll(socketDir)