github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-27 21:47:07 +00:00
Code Issues Projects Releases Wiki Activity

test: new beta version should be disabled by group,version

Browse Source
This commit is contained in:
Abu Kashem 2022-09-12 13:09:41 -04:00
parent eedf0ed221
commit 8e7c4353b0
No known key found for this signature in database
GPG Key ID: 33A4FA7088DB68A9
1 changed files with 62 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

62
pkg/controlplane/instance_test.go
View File

@ -341,6 +341,20 @@ func TestNoAlphaVersionsEnabledByDefault(t *testing.T) {
t.Errorf("Alpha API version %s enabled by default", gv.String()) t.Errorf("Alpha API version %s enabled by default", gv.String())
} }
} }
for gvr, enabled := range config.ResourceConfigs {
if !strings.Contains(gvr.Version, "alpha") || !enabled {
continue
}
// we have enabled an alpha api by resource {g,v,r}, we also expect the
// alpha api by version {g,v} to be disabled. This is so a programmer
// remembers to add the new alpha version to alphaAPIGroupVersionsDisabledByDefault.
gr := gvr.GroupVersion()
if enabled, found := config.GroupVersionConfigs[gr]; !found || enabled {
t.Errorf("Alpha API version %q should be disabled by default", gr.String())
}
}
} }
func TestNoBetaVersionsEnabledByDefault(t *testing.T) { func TestNoBetaVersionsEnabledByDefault(t *testing.T) {
@ -350,6 +364,54 @@ func TestNoBetaVersionsEnabledByDefault(t *testing.T) {
t.Errorf("Beta API version %s enabled by default", gv.String()) t.Errorf("Beta API version %s enabled by default", gv.String())
} }
} }
for gvr, enabled := range config.ResourceConfigs {
if !strings.Contains(gvr.Version, "beta") || !enabled {
continue
}
// we have enabled a beta api by resource {g,v,r}, we also expect the
// beta api by version {g,v} to be disabled. This is so a programmer
// remembers to add the new beta version to betaAPIGroupVersionsDisabledByDefault.
gr := gvr.GroupVersion()
if enabled, found := config.GroupVersionConfigs[gr]; !found || enabled {
t.Errorf("Beta API version %q should be disabled by default", gr.String())
}
}
}
func TestDefaultVars(t *testing.T) {
// stableAPIGroupVersionsEnabledByDefault should not contain beta or alpha
for i := range stableAPIGroupVersionsEnabledByDefault {
gv := stableAPIGroupVersionsEnabledByDefault[i]
if strings.Contains(gv.Version, "beta") || strings.Contains(gv.Version, "alpha") {
t.Errorf("stableAPIGroupVersionsEnabledByDefault should contain stable version, but found: %q", gv.String())
}
}
// legacyBetaEnabledByDefaultResources should contain only beta version
for i := range legacyBetaEnabledByDefaultResources {
gv := legacyBetaEnabledByDefaultResources[i]
if !strings.Contains(gv.Version, "beta") {
t.Errorf("legacyBetaEnabledByDefaultResources should contain beta version, but found: %q", gv.String())
}
}
// betaAPIGroupVersionsDisabledByDefault should contain only beta version
for i := range betaAPIGroupVersionsDisabledByDefault {
gv := betaAPIGroupVersionsDisabledByDefault[i]
if !strings.Contains(gv.Version, "beta") {
t.Errorf("betaAPIGroupVersionsDisabledByDefault should contain beta version, but found: %q", gv.String())
}
}
// alphaAPIGroupVersionsDisabledByDefault should contain only alpha version
for i := range alphaAPIGroupVersionsDisabledByDefault {
gv := alphaAPIGroupVersionsDisabledByDefault[i]
if !strings.Contains(gv.Version, "alpha") {
t.Errorf("alphaAPIGroupVersionsDisabledByDefault should contain alpha version, but found: %q", gv.String())
}
}
} }
func TestNewBetaResourcesEnabledByDefault(t *testing.T) { func TestNewBetaResourcesEnabledByDefault(t *testing.T) {