From 8f2aaf63d7b301bb2b1a1f9aec9c253a55de05f5 Mon Sep 17 00:00:00 2001 From: Mengjiao Liu Date: Wed, 27 Dec 2023 15:33:28 +0800 Subject: [PATCH] Fix incorrect error checking --- pkg/controller/cronjob/cronjob_controllerv2.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/controller/cronjob/cronjob_controllerv2.go b/pkg/controller/cronjob/cronjob_controllerv2.go index bb2da6bf080..246c9918e1f 100644 --- a/pkg/controller/cronjob/cronjob_controllerv2.go +++ b/pkg/controller/cronjob/cronjob_controllerv2.go @@ -203,8 +203,8 @@ func (jm *ControllerV2) sync(ctx context.Context, cronJobKey string) (*time.Dura updateStatusAfterCleanup := jm.cleanupFinishedJobs(ctx, cronJobCopy, jobsToBeReconciled) requeueAfter, updateStatusAfterSync, syncErr := jm.syncCronJob(ctx, cronJobCopy, jobsToBeReconciled) - if err != nil { - logger.V(2).Info("Error reconciling cronjob", "cronjob", klog.KObj(cronJob), "err", err) + if syncErr != nil { + logger.V(2).Info("Error reconciling cronjob", "cronjob", klog.KObj(cronJob), "err", syncErr) } // Update the CronJob if needed