From 8f966009079ca48119004255a749b45772060b5d Mon Sep 17 00:00:00 2001 From: yujunwang Date: Sat, 22 Jan 2022 23:45:29 +0800 Subject: [PATCH] perf:logic-optimiz-for-DetermineVolumeAction --- pkg/controller/volume/attachdetach/util/util.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/controller/volume/attachdetach/util/util.go b/pkg/controller/volume/attachdetach/util/util.go index 83fa5f8225c..dfcad47cc52 100644 --- a/pkg/controller/volume/attachdetach/util/util.go +++ b/pkg/controller/volume/attachdetach/util/util.go @@ -188,10 +188,10 @@ func DetermineVolumeAction(pod *v1.Pod, desiredStateOfWorld cache.DesiredStateOf if pod == nil || len(pod.Spec.Volumes) <= 0 { return defaultAction } - nodeName := types.NodeName(pod.Spec.NodeName) - keepTerminatedPodVolume := desiredStateOfWorld.GetKeepTerminatedPodVolumesForNode(nodeName) if util.IsPodTerminated(pod, pod.Status) { + nodeName := types.NodeName(pod.Spec.NodeName) + keepTerminatedPodVolume := desiredStateOfWorld.GetKeepTerminatedPodVolumesForNode(nodeName) // if pod is terminate we let kubelet policy dictate if volume // should be detached or not return keepTerminatedPodVolume