From 8fcb4b5773ab25f3075e393d229c3fcd910eeba9 Mon Sep 17 00:00:00 2001 From: Antonio Ojea Date: Mon, 20 Jan 2025 13:26:04 +0000 Subject: [PATCH] comment we keep storing v1beta1 by default to handle upgrades --- pkg/kubeapiserver/default_storage_factory_builder.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pkg/kubeapiserver/default_storage_factory_builder.go b/pkg/kubeapiserver/default_storage_factory_builder.go index 8ebda0944a4..044164ea158 100644 --- a/pkg/kubeapiserver/default_storage_factory_builder.go +++ b/pkg/kubeapiserver/default_storage_factory_builder.go @@ -74,6 +74,8 @@ func NewStorageFactoryConfig() *StorageFactoryConfig { // TODO (https://github.com/kubernetes/kubernetes/issues/108451): remove the override in 1.25. // apisstorage.Resource("csistoragecapacities").WithVersion("v1beta1"), coordination.Resource("leasecandidates").WithVersion("v1alpha2"), + // TODO(aojea) ipaddresses and servicecidrs are v1 in 1.33 + // remove them in 1.34 when all apiserver understand the v1 version. networking.Resource("ipaddresses").WithVersion("v1beta1"), networking.Resource("servicecidrs").WithVersion("v1beta1"), admissionregistration.Resource("mutatingadmissionpolicies").WithVersion("v1alpha1"),