github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-01 07:47:56 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #40342 from louyihua/remove_warning

Browse Source 
Automatic merge from submit-queue (batch tested with PRs 40111, 40368, 40342, 40274, 39443)

Eliminate "Unknown service type: ExternalName"

When creating an ExternalName service, rest.go still generate the warning message "Unknown service type: ExternalName". This should be eliminated as this type of service is supported now.
This commit is contained in:
Kubernetes Submit Queue 2017-01-31 19:18:41 -08:00 committed by GitHub
commit 8fe7a2decb
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/registry/core/service/rest.go
View File

@ -557,6 +557,8 @@ func shouldAssignNodePorts(service *api.Service) bool {
return true return true
case api.ServiceTypeClusterIP: case api.ServiceTypeClusterIP:
return false return false
case api.ServiceTypeExternalName:
return false
default: default:
glog.Errorf("Unknown service type: %v", service.Spec.Type) glog.Errorf("Unknown service type: %v", service.Spec.Type)
return false return false