From 901da441de0fcd24499df5dd9efd8ca89f18c18a Mon Sep 17 00:00:00 2001 From: Clayton Coleman Date: Tue, 16 Jul 2019 22:06:37 -0400 Subject: [PATCH] Add a feature gate for legacy node-role behavior This gate will default to on in 1.16 to cover the behavior of the existing system, and then in the future default to off and then be removed once all consumers have migrated. --- pkg/features/kube_features.go | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/pkg/features/kube_features.go b/pkg/features/kube_features.go index c0939e570be..896abbffb0f 100644 --- a/pkg/features/kube_features.go +++ b/pkg/features/kube_features.go @@ -172,6 +172,12 @@ const ( // Enable pods to set sysctls on a pod Sysctls featuregate.Feature = "Sysctls" + // owner @smarterclayton + // alpha: v1.16 + // + // Enable legacy behavior to vary cluster functionality on the node-role.kubernetes.io labels. On by default (legacy), will be turned off in 1.18. + LegacyNodeRoleBehavior featuregate.Feature = "LegacyNodeRoleBehavior" + // owner @brendandburns // alpha: v1.9 // @@ -570,5 +576,6 @@ var defaultKubernetesFeatureGates = map[featuregate.Feature]featuregate.FeatureS // features that enable backwards compatibility but are scheduled to be removed // ... - HPAScaleToZero: {Default: false, PreRelease: featuregate.Alpha}, + HPAScaleToZero: {Default: false, PreRelease: featuregate.Alpha}, + LegacyNodeRoleBehavior: {Default: true, PreRelease: featuregate.Alpha}, }